Bug 798717

Summary:	The ksmtuned.service has no "retune" operation
Product:	[Retired] oVirt	Reporter:	Rami Vaknin <rvaknin>
Component:	vdsm	Assignee:	Dan Kenigsberg <danken>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	abaron, acathrow, bazulay, dfediuck, drjones, iheim, jkt, mgoldboi, rvaknin, yeylon
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	sla
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-25 07:25:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rami Vaknin 2012-02-29 16:14:25 UTC

Version:
vdsm-4.9.4-0.59.gitf01998b.fc16.x86_64

VDSM uses the retune operation of the ksmtuned service, while this operation does not exist in Fedora 16 systemd's ksmtuned.service

Thread-16093::DEBUG::2012-02-29 16:55:23,705::utils::601::Storage.Misc.excCmd::(execCmd) '/usr/bin/sudo -n /sbin/service ksmtuned retune' (cwd None)
Thread-16093::DEBUG::2012-02-29 16:55:23,746::utils::601::Storage.Misc.excCmd::(execCmd) FAILED: <err> = 'Unknown operation retune\n'; <rc> = 1

Comment 1 Dan Kenigsberg 2012-03-03 20:40:31 UTC

I would say that this is a ksmtuned bug, not Vdsm's. Also, this may become redundant with MOM looming in http://gerrit.ovirt.org/2367

Comment 2 Rami Vaknin 2012-03-04 14:47:21 UTC

Maybe.

Until it becomes redundant, note that the side effect of the above problem is more external commands that don't care that the "retune" operation failed:

"pgrep -xf ksmd"
"kill -9 process_id" - fails

Comment 3 Rami Vaknin 2012-03-05 09:40:29 UTC

Please disregard my last comment, it's not related to this bug.

Comment 4 Andrew Jones 2013-01-21 14:38:05 UTC

(In reply to comment #1)
> I would say that this is a ksmtuned bug, not Vdsm's. Also, this may become
> redundant with MOM looming in http://gerrit.ovirt.org/2367

Hmm, there is no 'retune' command for systemd controlled daemons. I see in /usr/lib/systemd/system/ksmtuned.service on my f17 machine that 'retune' has now been remapped to 'reload'. I believe the best solution is for VDSM to support both - switching commands depending on which interface (service or systemctl) is used for the system. Using 'service' to manage systemd scripts as is shown in comment 0 should be avoided as well.

Comment 5 Doron Fediuck 2013-07-25 07:25:13 UTC

Starting oVirt 3.3 vdsm will use mom and ksm without ksmtuned. See bug 987926.
Therefore this issue is no longer relevant, and closing as such.

Comment 6 Rami Vaknin 2013-07-25 08:48:39 UTC

OK. Any info requested from my side?

Comment 7 Doron Fediuck 2013-07-25 09:43:27 UTC

(In reply to Rami Vaknin from comment #6)
> OK. Any info requested from my side?

No info needed. Just wanted you to notice.