| Summary: | Logic error in send_stopped_status function in node/cartridges/abstract/info/lib/util | ||
|---|---|---|---|
| Product: | OKD | Reporter: | Johnny Liu <jialiu> |
| Component: | Containers | Assignee: | Dan McPherson <dmcphers> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.x | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-02 21:56:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Fixed for stage. Verified this bug with rhc-node-0.87.9-1, and PASS |
Description of problem: In node/cartridges/abstract/info/lib/util: function send_stopped_status { _state=`get_app_state` case "$_state" in idle) send_attr "status=ALREADY_IDLED" ;; stopped) send_attr "status=ALREADY_STOPPED" ;; *) if [ -f $APP_DIR/run/stop_lock ] then send_attr "status=ALREADY_IDLED" else HTTP_DIR=`dirname "/etc/httpd/conf.d/libra/${uuid}"*/00000_default.conf` if [ -f $HTTP_DIR/0000000000000_disabled.conf ] then send_attr "status=ALREADY_IDLED" else send_attr "status=ALREADY_STOPPED" fi fi ;; esac } For *) branch, if $APP_DIR/run/stop_lock file exists, this app maybe stopped or idled, it is not necessarily "status=ALREADY_IDLED", need do more test What about this: *) if [ -f $APP_DIR/run/stop_lock ] then HTTP_DIR=`dirname "/etc/httpd/conf.d/libra/${uuid}"*/00000_default.conf` if [ -f $HTTP_DIR/0000000000000_disabled.conf ] then send_attr "status=ALREADY_IDLED" else send_attr "status=ALREADY_STOPPED" fi fi Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: