Bug 799023
Summary: | Review Request: eot-utils - Tools to convert OTF/TTF to EOT font format and show its metadata | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jan Pokorný [poki] <jpokorny> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, panemade, petersen, pnemade, psatpute |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-03-15 09:35:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jan Pokorný [poki]
2012-03-01 15:29:51 UTC
Review: - koji build failed (f17) ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3845922 + source verified with upstream as (sha1sum) 7e8a68ba1ae4b533113e7965aa2cca133367f31f eot-utilities-1.1.tar.gz 7e8a68ba1ae4b533113e7965aa2cca133367f31f ../SOURCES/eot-utilities-1.1.tar.gz Suggestions: 1) you need to remove autoreconf from %build as this will pass the scratch build on koji. 2) install section change from rm -rf -- $RPM_BUILD_ROOT make install-strip DESTDIR=$RPM_BUILD_ROOT to make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" (In reply to comment #1) > 1) you need to remove autoreconf from %build as this will pass > the scratch build on koji. Agreed, I've just found [1] and it works well for me without it in the mock environment. (Otherwise, these BuildRequires would be needed: autoconf, automake, m4.) > 2) install section change from > rm -rf -- $RPM_BUILD_ROOT > make install-strip DESTDIR=$RPM_BUILD_ROOT > to > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" The removal command comes from rpmdev-newspec. If this is not needed or it serves only to ensure everything is rebuilt properly when building locally, bug against rpmdevtools should be filed. Re: INSTALL="install -p" ... agreed. Re: install-strip -> install: I got it, it is a matter of postprocessing that will create separate debuginfo package and actually strip the binaries. (Interestingly, "install-strip" will not do the stripping in this case either.) [1] http://stackoverflow.com/a/7754416 Spec and SRPM available at the same URLs (the old version is in "old-v1"). I've also returned "meta-data" back to "metadata" (as in Summary) and use the form of RPM macros consistently. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3846459 Always bump the release for new update in package. Change summary from Summary: Tools to convert OTF/TTF to EOT font format + show its metadata to Summary: Tools to convert OTF/TTF to EOT font format and show its metadata Good to make it more readable. And if you want to follow spec format what rpmdev-newspec gives then use rm -rf $RPM_BUILD_ROOT All is addressed in -2 (I've thought versioning starts since the real package inclusion, maybe I overlooked it in the guidelines). http://jpokorny.fedorapeople.org/eot-utils/eot-utils.spec http://jpokorny.fedorapeople.org/eot-utils/eot-utils-1.1-2.fc16.src.rpm koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3856615 APPROVED. Thanks, Parag. New Package SCM Request ======================= Package Name: eot-utils Short Description: Tools to convert OTF/TTF to EOT font format and show its metadata Owners: jpokorny Branches: f15 f16 el6 InitialCC: (leaving InitialCC empty, but pravins, other CC'd to this bug or fonts-sig may be appropriate) Paragn, could you sponsor me into the packager group as well, please? oh! you are not yet sponsored? Okay I have sponsored you now :) Git done (by process-git-requests). Added f17 branch. Packages: f15: https://admin.fedoraproject.org/updates/eot-utils-1.1-2.fc15 ... f18: https://admin.fedoraproject.org/updates/eot-utils-1.1-2.fc18 el6: https://admin.fedoraproject.org/updates/eot-utils-1.1-2.el6 You can close this review as package is built for f18/devel. Ok, thanks for help. |