| Summary: | Present warning with confirmation on promotion of changeset with failed repo sync | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Og Maciel <omaciel> | ||||||
| Component: | API | Assignee: | Justin Sherrill <jsherril> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Katello QA List <katello-qa-list> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 6.0.0 | CC: | bkearney, inecas, jrist, jsherril, mmccune, sghai, tsanders | ||||||
| Target Milestone: | Unspecified | Keywords: | Triaged | ||||||
| Target Release: | Unused | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-05-15 18:55:59 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
|
Description
Og Maciel
2012-03-01 20:01:45 UTC
by only allowing promotion if there are no sync errors, we also bring up the question of "Do we allow you to promote an unsynced repository?" Currently we do. Two such changes could be made: 1. only properly synced repos are allowed to be promoted. Ones that had not been synced could not be promoted. I seem to remember at one point we required at least 1 sync before allowing promotion, this changed for some reason, do we want to go back to that? 2. only allow promotion of a repo if it has been synced with no errors or has never been synced. This just seems silly, as we would allow you to promote until you tried to unsuccessfully sync. Thoughts? At a first glance I like option (1). Furthermore, if for whatever reason I make changes to my product and the sync after those changes fail, I'd recommend that the user should not promote until all reasons for breaking the synchronization process are ironed out to prevent perfectly good environments to get corrupted. After a lengthy discussion I believe we settled on the following: If a product contains a repository that has a failed sync and the user has added some part of the product to the changeset we will present a warning message to them saying that a specified repository has failed to sync and could cause errors in the promotion. The user will then have to manually click continue. We did this because we did not want to intentionally prohibit the user from promoting 6.1 content for example, if 6.0 failed to sync. should be fixed in katello master: ce58078895b2a9997e14586f057ef0a1650bff24 to clarify after this change, when hitting promote, if some product in the changeset has a repo that is either currently syncing or has an error on its last sync, we will show a warning. The user can still continue or cancel, but we are at least warning the user. I tried to verify this defect with following build: pulp-1.0.0-6.el6.noarch katello-0.1.306-1.el6.noarch mod_wsgi-3.3-3.pulp.el6.x86_64 katello-glue-candlepin-0.1.306-1.el6.noarch pulp-common-1.0.0-6.el6.noarch m2crypto-0.21.1.pulp-7.el6.x86_64 candlepin-0.5.26-1.el6.noarch pulp-selinux-server-1.0.0-6.el6.noarch katello-glue-pulp-0.1.306-1.el6.noarch katello-candlepin-cert-key-pair-1.0-1.noarch python-oauth2-1.5.170-2.pulp.el6.noarch candlepin-tomcat6-0.5.26-1.el6.noarch katello-cli-0.1.107-1.el6.noarch However, couldn't see the warning message when repo associated to selected product is in sync and user is trying to promote the same product. I tried from cli as well as from UI. UI raised another weird error so for that I logged a another defect (806801). Hi Justin, could you please confirm if this defect is fixed in 0.1.306 ? Verified with following build: pulp-1.0.0-8.el6.noarch katello-0.1.307-1.el6.noarch katello-cli-0.1.107-1.el6.noarch Warning message is added when we promote a product and the associated repo is being synced. Please see the attachment in next comment. Created attachment 573638 [details]
warning msg raised during promotio of repo which is being synced
Reverified this with following CFSE build: katello-0.1.307-1.el6.noarch pulp-1.0.2-1.el6.noarch Proper warning messages are raised when promoting the product which is either being synced or has an error on its last sync. Created attachment 573912 [details]
warning message when the sync has failed for the repo and we are trying to promote it to next env
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-0665.html |