Bug 799243

Summary: Failing ExpressionAssignmentHandler jBPM tests.
Product: [JBoss] JBoss Enterprise SOA Platform 5 Reporter: Marek Baluch <mbaluch>
Component: JBPM - within SOAAssignee: Nobody <nobody>
Status: VERIFIED --- QA Contact: Marek Baluch <mbaluch>
Severity: medium Docs Contact:
Priority: low    
Version: 5.3.0 GACC: mvecera, rwagner, soa-p-jira
Target Milestone: ER2   
Target Release: 5.3.0 GA   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.3.0 GA Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Marek Baluch 2012-03-02 09:00:27 UTC 
Description of problem:

Method org.jbpm.logging.exe.LoggingInstance.getLogs() has changed. It now returns an umodifiable collection. This causes the following two tests to fail

org.jbpm.identity.assignment.ExpressionAssignmentHandlerTest.testFirstTermVariableUser
org.jbpm.identity.assignment.ExpressionAssignmentHandlerTest.testFirstTermVariableGroup 

with message:

ava.lang.UnsupportedOperationException
	at java.util.Collections$UnmodifiableCollection$1.remove(Collections.java:1028)
	at org.jbpm.identity.assignment.ExpressionAssignmentHandlerTest.deleteLogs(ExpressionAssignmentHandlerTest.java:163)
	at org.jbpm.identity.assignment.ExpressionAssignmentHandlerTest.testFirstTermVariableUser(ExpressionAssignmentHandlerTest.java:142)
	at org.jbpm.db.AbstractDbTestCase.runTest(AbstractDbTestCase.java:73)
Comment 1 Marco Rietveld 2012-03-02 18:57:05 UTC 
Marek, 

This _was_ a problem, but I'm pretty sure I fixed it: 

http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbpm/jbpm3/branches/jbpm-3.2-soa/core/src/main/java/org/jbpm/logging/exe/LoggingInstance.java?r1=7060&r2=7072

See https://svn.jboss.org/repos/jbpm/jbpm3/tags/jbpm-3.2.12/core/src/main/java/org/jbpm/logging/exe/LoggingInstance.java
as well, where this is: 

  /**
   * If you modify the returned list in any way, you run the risk 
   * of causing exceptions in a concurrent situation. 
   * 
   * @return The list of logs
   */
  public List getLogs() {
    return logs;
  }

Maybe mead or the build grabbed it too early? 

(or did I miss something?)
Comment 2 Marek Baluch 2012-03-05 06:34:38 UTC 
Yes this one is related to the build process. It grabbed revision 7071. 

Thanks Marco
Comment 3 Rick Wagner 2012-03-19 21:38:04 UTC 
Looks done, low priority.
Comment 4 Marek Baluch 2012-05-02 11:39:50 UTC 
Verified on ER2.