Bug 799488

[root@qeblade21 nodes]# rpm -qa | grep "aeolus-cli"
rubygem-aeolus-cli-0.3.0-12.el6.noarch

aeolus-configure should have a better error message if any of the parameters in aeolus-configure/nodes/$config_file are incorrect

Seems to be fixed in https://github.com/aeolusproject/aeolus-configure/commit/bfa5682f5cbc38a70b80a15a79f540801fb89482

"Invalid parameter password on node qeblade21.rhq.lab.eng.bos.redhat.com"
means that $password was not valid parameter for our puppet function. It doesn't mean that contents of $password itself was invalid.
So the error message is valid (but still confusing), stating that error occurred on qeblade21 which is correct because that's where it was run on and where puppet scripts were located.

The commit above fixes that error by reintroducing $password as a valid parameter.

It seems all the validation from vsphere is removed for the fix.I intentionally left all the paramater values(default dummy values) unchanged in both vsphere and rhevm configure files.

[root@dhcp201-113 ~]# tail -8 /etc/aeolus-configure/nodes/vsphere_configure 
      default:
        # Uncomment and provide values to match your vSphere environment.
        # Values below are examples.
          deltacloud_provider: vsphere.server.com
          username: username
          password: password
          datastore: datastore
          network_name: network_name
[root@dhcp201-113 ~]# tail -8 /etc/aeolus-configure/nodes/rhevm_configure
          nfs_server: nfs.server.com
          nfs_export: /export/export_domain
          nfs_mount_point: /mnt/rhevm-nfs
          deltacloud_username: username@fqdn
          deltacloud_password: password
          deltacloud_api: https://rhevm.server.com:8443/api
          deltacloud_data_center: data center id
          push_timeout: 1800

And here is the output:-

[root@dhcp201-113 ~]# aeolus-configure -p vsphere
Launching aeolus configuration recipe...
notice: /File[/etc/ldap_fluff.yml]/content: content changed '{md5}b27213de9f26cf3a5e689c1ab7d2c2b6' to '{md5}109fb977032121710c47df851d8f0e72'
notice: /File[/etc/ldap_fluff.yml]/group: group changed 'root' to 'aeolus'
notice: /File[/etc/ldap_fluff.yml]/mode: mode changed '644' to '640'
notice: /File[/usr/share/aeolus-conductor/config/initializers/secret_token.rb]/ensure: defined content as '{md5}dd58e9d517a374c07b27f76f69880bce'
notice: /File[/usr/share/aeolus-conductor/config/settings.yml]/content: content changed '{md5}e554310b717ab9218f4d136cdc7994f4' to '{md5}e9e9f46bfcd6c8646c9da4652a6c4625'
notice: /Stage[main]/Aeolus::Image-factory/Augeas[imagefactory.conf]/returns: executed successfully
notice: /Stage[main]/Postgres::Server/Service[postgresql]/ensure: ensure changed 'stopped' to 'running'
notice: /Stage[main]/Aeolus  

.............
notice: /Stage[main]/Aeolus::Profiles::Common/Aeolus::Conductor::Destroy_temp_admins[after]/Exec[destroy_temp_admin-after]/returns: executed successfully
notice: Finished catalog run in 61.27 seconds


[root@dhcp201-113 ~]# aeolus-configure -p rhevm
Launching aeolus configuration recipe...
Couldn't resolve host name at /usr/share/aeolus-configure/modules/aeolus/manifests/rhevm/validate.pp:2 on node dhcp201-113.englab.pnq.redhat.com



So rhevm-configure behaved correctly with invalid parameter values where fo vsphere-configure it is unable to provide any information regarding invalid parametrs instead it succeed with configuring.

I feel this problem needs more fixes. Marking as Assigned.

Opened a new bug for validation checks in:-
aeolus-configure -p vsphere

https://bugzilla.redhat.com/show_bug.cgi?id=859034 

Marking this verified after brief disscussion with mzatko as password problem is fixed.IMHO i still feel https://bugzilla.redhat.com/show_bug.cgi?id=859034 is a side effect of this fix or a result of a incomplete fix.