Bug 799597
Summary: | Review Request: php-pecl-xhprof - A Hierarchical Profiler for PHP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
Component: | Package Review | Assignee: | Johan Cwiklinski <fedora> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dan, fedora, mrunge, notting, package-review |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | php-pecl-xhprof-0.9.2-5.fc16 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-05-19 06:56:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Remi Collet
2012-03-03 10:35:27 UTC
* Mon Mar 05 2012 Remi Collet <remi> - 0.9.2-4 - rename patches - install html and lib under /usr/share/xhprof https://github.com/remicollet/remirepo/commit/e83d13f2a5aa2a5f75802e91355ecf56c3e2460d http://rpms.famillecollet.com/SRPMS/php-pecl-xhprof-0.9.2-4.remi.src.rpm REVIEW : + rpmlint is ok % rpmlint -i /var/lib/mock/fedora-16-x86_64/result/*.rpm php-pecl-xhprof.src: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled The value of this tag appears to be misspelled. Please double-check. php-pecl-xhprof.x86_64: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled The value of this tag appears to be misspelled. Please double-check. xhprof.noarch: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled The value of this tag appears to be misspelled. Please double-check. xhprof.noarch: W: spelling-error %description -l en_US pecl -> peck, peel, pecs The value of this tag appears to be misspelled. Please double-check. xhprof.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml The value of this tag appears to be misspelled. Please double-check. 4 packages and 0 specfiles checked; 0 errors, 5 warnings. + package is named according to the Package Naming Guidelines . + spec file name ok + The package meet the Packaging Guidelines and PHP Guidelines + license ok (ASL) and match upstream + license provided + spec file is legible + sources match upstream ae40b153d157e6369a32e2c1a59a61ec xhprof-0.9.2.tgz + source URL ok + build on F16 x86_64 (php 5.3.10) + build on mock + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + small doc, no sub package + doc not required to run + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + %check ok (only load test) + load in httpd ok + test ok (after install) + scriptlet ok ***** APPROVED ***** Thanks for this review. New Package SCM Request ======================= Package Name: php-pecl-xhprof Short Description: A Hierarchical Profiler for PHP Owners: remi Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). php-pecl-xhprof-0.9.2-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-pecl-xhprof-0.9.2-5.fc17 php-pecl-xhprof-0.9.2-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-pecl-xhprof-0.9.2-5.fc16 php-pecl-xhprof-0.9.2-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pecl-xhprof-0.9.2-5.el6 php-pecl-xhprof-0.9.2-5.el6 has been pushed to the Fedora EPEL 6 testing repository. php-pecl-xhprof-0.9.2-5.fc16 has been pushed to the Fedora 16 stable repository. Remi, I think this package should be made ExclusiveArch: %{i86} x86_64 because the cycle_timer() function using the RDTSC instruction is x86 specific. (In reply to comment #10) > Remi, I think this package should be made ExclusiveArch: %{i86} x86_64 > because the cycle_timer() function using the RDTSC instruction is x86 > specific. And adding a ppc/ppc64 implementation of RDTSC will still make it fail to build on s390(x) and arm and others. Thanks for the information. Done : http://pkgs.fedoraproject.org/gitweb/?p=php-pecl-xhprof.git;a=commitdiff;h=3003533307dc4b1290ba18038ca025416a92f417 And thanks for the update :-) php-pecl-xhprof-0.9.2-5.fc17 has been pushed to the Fedora 17 stable repository. php-pecl-xhprof-0.9.2-5.el6 has been pushed to the Fedora EPEL 6 stable repository. |