Bug 800134

Summary: Bugs found in python-GeoIP-1.2.5-0.4.20090931cvs.fc15 using gcc-with-cpychecker static analyzer
Product: [Fedora] Fedora Reporter: Dave Malcolm <dmalcolm>
Component: python-GeoIPAssignee: Matt Domsch <matt_domsch>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: mfleming+rpm
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-03-05/python-GeoIP-1.2.5-0.4.20090931cvs.fc15/
Whiteboard:
Fixed In Version: python-GeoIP-1.2.8-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-09 18:39:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 789472    

Description Dave Malcolm 2012-03-05 19:50:42 UTC 
Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:
  https://fedorahosted.org/gcc-python-plugin/
  http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html
  http://fedoraproject.org/wiki/Features/StaticAnalysisOfPythonRefcounts

I ran the latest version of the tool (in git master; post 0.9) on
python-GeoIP-1.2.5-0.4.20090931cvs.fc15.src.rpm, and it reports various errors.

You can see a list of errors here, triaged into categories (from most significant to least significant):
http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-03-05/python-GeoIP-1.2.5-0.4.20090931cvs.fc15/

I've manually reviewed the issues reported by the tool.

Within the category "Reference leaks" the 2 issues reported appear to be genuine leaks; the error-handling paths appear to need a: Py_DECREF(GeoIP)

Within the category "Segfaults within error-handling paths" the 12 issues reported appear to be genuine bugs that could occur under low-memory conditions (where an allocation fails, returning NULL).

Within the category "Returning (PyObject*)NULL without setting an exception" the 1 issue reported may or may not be a real bug, depending on whether GeoIP_range_by_ip() sets the thread's exception status when it returns NULL.

There may of course be other bugs in my checker tool.

Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.

Version-Release number of selected component (if applicable):
python-GeoIP-1.2.5-0.4.20090931cvs.fc15
gcc-python-plugin post-0.9 git 11462291a66c8db693c8884cb84b795bb5988ffb running the checker in an *f16* chroot
Comment 1 Fedora Admin XMLRPC Client 2013-03-07 19:17:50 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 2 Matt Domsch 2013-03-08 02:14:02 UTC 
Dave, where is the /test.py script referenced in the gcc invocation?

I built the latest version of this package into rawhide today.  I'd like to see if it fails in a way similar to the bugs you note here, before it gets too far into F19's release process.  Perhaps you can re-run your check based on rawhide tomorrow?

Thanks,
Matt
Comment 3 Matt Domsch 2013-03-08 04:21:36 UTC 
reported to support.
Comment 4 Fedora End Of Life 2013-04-03 16:05:19 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
Comment 5 Matt Domsch 2013-05-09 18:39:50 UTC 
python-GeoIP-1.2.8-1.fc20 and .fc19 built now, which includes changes made by upstream after I submitted this bug report to them.

Dave, can you re-run your test against this version please?

Closing for now - Dave can reopen if issues still exist.
Comment 6 Fedora Update System 2013-05-09 18:44:14 UTC 
python-GeoIP-1.2.8-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-GeoIP-1.2.8-1.fc19
Comment 7 Fedora Update System 2013-11-17 07:05:02 UTC 
python-GeoIP-1.2.8-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.