Bug 800146
| Summary: | Bugs found in python-ethtool-0.7-2.fc16 using gcc-with-cpychecker static analyzer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Malcolm <dmalcolm> |
| Component: | python-ethtool | Assignee: | David Sommerseth <davids> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | acme, davids, ovasik |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-03-05/python-ethtool-0.7-2.fc16/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-18 13:41:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 789472 | ||
| Attachments: | |||
|
Description
Dave Malcolm
2012-03-05 20:26:06 UTC
Created attachment 570663 [details]
[PATCH 1/3] Do not allocate a PyList before needed in get_devices()
Created attachment 570664 [details]
[PATCH 2/3] Don't presume PyString_FromStrin() never returns NULL
Created attachment 570665 [details]
[PATCH 3/3] More fixes to get_interfaces_info() in error situations
More patches will come to take care of the rest of the issues. (In reply to comment #2) > Created attachment 570664 [details] > [PATCH 2/3] Don't presume PyString_FromStrin() never returns NULL Why do you call: PyErr_SetString(PyExc_MemoryError, strerror(errno)); on the error-handling path? PyString_FromString has already set an exception when it returns NULL (In reply to comment #3) > Created attachment 570665 [details] > [PATCH 3/3] More fixes to get_interfaces_info() in error situations Is there a reason for capturing strerror(errno)? The idiom is to use PyErr_NoMemory; see http://docs.python.org/c-api/exceptions.html#PyErr_NoMemory (In reply to comment #1) > Created attachment 570663 [details] > [PATCH 1/3] Do not allocate a PyList before needed in get_devices() The PyList_New call can fail, returning NULL and setting an exception. You probably should add a: if (!list) { return NULL; } immediately after the call. This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |