Bug 801073

Please update the srpm with latest upstream tarball

(In reply to comment #1)
> Please update the srpm with latest upstream tarball

SPEC: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx.spec
SRPM: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx-0.3.3-1.fc16.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4091556

Review:
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4091556

+ rpmlint on rpms gave
kcm-fcitx.x86_64: E: incorrect-fsf-address /usr/share/doc/kcm-fcitx-0.3.3/COPYING
kcm-fcitx.x86_64: E: zero-length /usr/share/doc/kcm-fcitx-0.3.3/README
2 packages and 0 specfiles checked; 2 errors, 0 warnings.

+ Source verified with upstream as (sha1sum)
83a431d51df5cb2fa049e8e59ab5ccc3685adde0  kcm-fcitx-0.3.3.tar.xz
83a431d51df5cb2fa049e8e59ab5ccc3685adde0  ../SOURCES/kcm-fcitx-0.3.3.tar.xz

+ Package kcm-fcitx-0.3.3-1.fc18.x86_64 =>
 Provides: kcm-fcitx = 0.3.3-1.fc18 kcm-fcitx(x86-64) = 0.3.3-1.fc18 kcm_fcitx.so()(64bit)
 Requires: libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.8)(64bit) libfcitx-config.so.4()(64bit) libfcitx-core.so.0()(64bit) libfcitx-utils.so.0()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libknewstuff3.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) rtld(GNU_HASH)


Suggestions:
1) Good to use commands in spec actually.
replace
%{__mkdir} -pv build
with
mkdir -pv build

2) Remove the zero-length files from installation. For this package remove README from %doc

3) I can't see MimeType key written in desktop files. There is no need of writing http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database in spec file. Please remove it.

Kcm's need a dependency:

# need kcmshell4 from kde(base)-runtime at least
Requires: kdebase-runtime%{?_kde4_version: >= %{_kde4_version}}

I notice too that the pkg summary/description doesn't match what's listed on
http://code.google.com/p/fcitx/

the current ones don't mention input methods at all, and upstream site doesn't mention anything about service menus or GHNS

I updated a new spec file and a new SRPM packages. Please continue to review it. 

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094928

SPEC: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx.spec
SRPM: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx-0.3.3-1.fc16.src.rpm

Several suggestions:

1.  replace
cat << EOF > %{name}.lang 
%lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
%lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
EOF

with
%find_lang %{name}


2.  in %build

you have
pushd build

but no matching
popd


3.  (cosmetics, but shorter) in %install, replace
pushd build
make install DESTDIR=$RPM_BUILD_ROOT
popd

with
make install  DESTDIR=$RPM_BUILD_ROOT -C build

%find_lang %{name} is not going to work because %{name} uses a '-' rather than an '_'. You'll have to use %find_lang kcm_fcitx. (Or maybe the package should be called kcm_fcitx? But the tarball doesn't match that. We have this mess about kcm-* vs. kcm_* because of Debian's restrictive package name policies which ban underscores.)

ah, in that case,

find_lang %{name} --all-name --with-kde

to be on the safe side. :)

I have updated the latest SPEC file and SRPM file. 

SPEC: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx.spec
SRPM: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx-0.3.3-1.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4096647

(In reply to comment #7)
> Several suggestions:
> 
> 1.  replace
> cat << EOF > %{name}.lang 
> %lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
> %lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
> EOF
> 
> with
> %find_lang %{name}
> 

Fixed

> 
> 2.  in %build
> 
> you have
> pushd build
> 
> but no matching
> popd
> 

Fixed

> 
> 3.  (cosmetics, but shorter) in %install, replace
> pushd build
> make install DESTDIR=$RPM_BUILD_ROOT
> popd
> 
> with
> make install  DESTDIR=$RPM_BUILD_ROOT -C build


Fixed

(In reply to comment #9)
> ah, in that case,
> 
> find_lang %{name} --all-name --with-kde
> 
> to be on the safe side. :)

Looks fine now. Thanks others also for your inputs. 

Just remove README from %doc as its zero-length file.

APPROVED.

New Package SCM Request
=======================
Package Name: kcm-fcitx
Short Description: KDE Config Module for Fcitx
Owners: liangsuilong
Branches: f15 f16 f17 el6
InitialCC: i18n-team

Git done (by process-git-requests).

kcm-fcitx-0.3.3-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/kcm-fcitx-0.3.3-1.fc16

kcm-fcitx-0.3.3-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/kcm-fcitx-0.3.3-1.fc15

kcm-fcitx-0.3.3-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/kcm-fcitx-0.3.3-1.fc17

kcm-fcitx-0.3.3-1.fc17 has been pushed to the Fedora 17 testing repository.

any update here?

kcm-fcitx-0.3.3-1.fc17 has been pushed to the Fedora 17 stable repository.

kcm-fcitx-0.3.3-1.fc15 has been pushed to the Fedora 15 stable repository.

kcm-fcitx-0.3.3-1.fc16 has been pushed to the Fedora 16 stable repository.