Bug 802124

Summary: make rpm and srpm uses `git ls-files` to populate which files to compress.
Product: [Retired] oVirt Reporter: Raboo <raboo>
Component: ovirt-engine-installerAssignee: Ofer Schreiber <oschreib>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: acathrow, iheim, mgoldboi, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-17 07:26:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Raboo 2012-03-11 14:01:47 UTC
I wanna create rpms from the source, latest stable tarball.

[root@virtual ovirt-engine]# make rpm
tar zcf ovirt-engine-3.0.0_0001.tar.gz `git ls-files`
fatal: Not a git repository (or any of the parent directories): .git
tar: Cowardly refusing to create an empty archive
Try `tar --help' or `tar --usage' for more information.
make: *** [ovirt-engine-3.0.0_0001.tar.gz] Error 2

[root@virtual ovirt-engine]# make srpm
tar zcf ovirt-engine-3.0.0_0001.tar.gz `git ls-files`
fatal: Not a git repository (or any of the parent directories): .git
tar: Cowardly refusing to create an empty archive
Try `tar --help' or `tar --usage' for more information.
make: *** [ovirt-engine-3.0.0_0001.tar.gz] Error 2

Problem is I did not fetch ovirt git repo.
Shouldn't tar populate the files it should tar in some other way perhaps?

Comment 1 Ofer Schreiber 2012-05-08 07:59:47 UTC
`git ls-files` is the best option so far.
If you'd like to create new rpm, you probably want to use git.

Comment 2 Itamar Heim 2012-12-17 07:26:14 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.