Bug 802178

Summary:	logrotate script for proftpd w/ systemd (i.e. f16 and later) broken
Product:	[Fedora] Fedora	Reporter:	Philip Prindeville <philipp>
Component:	proftpd	Assignee:	Matthias Saou <matthias>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	16	CC:	matthias, paul, philipp
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	proftpd-1.3.4a-7.fc16	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-03-24 09:37:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Philip Prindeville 2012-03-11 22:06:08 UTC

Description of problem:

The /etc/logrotate.d/proftpd script for 16 and later contains:

test -f /var/lock/subsys/proftpd && /usr/bin/killall -HUP proftpd || :

but this file doesn't apply to sites using systemd to launch proftpd. It should be:

systemctl reload proftpd.service

instead. 

Version-Release number of selected component (if applicable):

proftpd-1.3.4a-5

How reproducible:

Wait for log rotation, then do either grep for proftpd restarting in log files, or else do:

ps -ef | grep proftpd
lsof -p XXXX | grep /var/log

and you'll see proftpd still holding rotated logs open.



Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Fedora Update System 2012-03-12 16:10:50 UTC

proftpd-1.3.4a-7.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/proftpd-1.3.4a-7.fc17

Comment 2 Fedora Update System 2012-03-12 16:10:59 UTC

proftpd-1.3.4a-7.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/proftpd-1.3.4a-7.fc16

Comment 3 Philip Prindeville 2012-03-13 04:14:42 UTC

Thanks, by the way, for taking care of that so quickly.

Comment 4 Fedora Update System 2012-03-16 21:17:48 UTC

proftpd-1.3.4a-7.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2012-03-24 00:33:25 UTC

proftpd-1.3.4a-7.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.