Bug 802550

Created attachment 569496 [details]
proposed patch

Attaching a patch for adding such configuration property to the agent and plugin container configuration.

If this is tested and easily testable then lets apply the patch

master commit: de1000f

I followed this scenario:
1. Configure the agent to have both server and service discovery periods set to an hour (3600s) and set rhq.agent.plugins.child-discovery.delay-secs to 120s
2. import rhq-agent
3. check all imported resources -> platform's and rhq-agent's child resources was imported 
4. after 120s i can see in agent.log 'Executing runtime discovery scan rooted at [platform]' -> after this, child resources of agent's child resources was imported

Example: right after i imported the agent, i could see the JVM resource as a agent's child. The JVM had no child resources. After 120s JMV's child resources was imported. 

According to description of rhq.agent.plugins.child-discovery.delay-secs in agent-configuration.xml i would expect that all agent's child resources (including the JVM) should be imported after 120s.

bug 823942 has very recently changed the same area in InventoryManager that this patch changed. I'm not sure how it affected it, but its possible.

See this commit:

http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commit;h=14d53ea73b219a85d1b54584457ed48a60e1a556

(In reply to comment #5)
> bug 823942 has very recently changed the same area in InventoryManager that
> this patch changed. I'm not sure how it affected it, but its possible.
> 
> See this commit:
> 
> http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commit;
> h=14d53ea73b219a85d1b54584457ed48a60e1a556

That was Jay's commit. We still aren't sure if that commit has anythign to do with this. Plus, the patch for this issue was very simple - just added a new config to avoid hardcoding the "5" in the code.

Jay and I aren't sure if there is anything wrong here. Looking at this further, but we may need more input from Lukas to see if this really is still broken or not. In fact, I'll add a NEEDINFO here for Lukas to chime in since it was his patch that introduced this new config option to fix the issue.

<lkrejci> mazz: i thought that was more of a documentation issue actually... i think filip's expectation was that *all* the child resources are going to get discovered after that delay
<lkrejci> but because our discovery is incremental per level, the delay is applied before *each* child discovery, at each level
<lkrejci> i think that was his complaint... and i think that it therefore works as designed, only the docs are not clear enough

Filip, can you confirm this is what you're seeing/expecting?

I think maybe he is wondering why the JVM child is discovered immediately and not deferred like the other children.

Yes Jay, i expected that even immediate children would be discovered after defined delay. Lukas clarified that following is correct and expected behaviour:1- after manual import of resource, his immediate children are discovered immediately
2- children on a next level are discovered after rhq.agent.plugins.child-discovery.delay-secs
3- children on a next level are discovered after rhq.agent.plugins.child-discovery.delay-secs
4-... recursively

Leaving in ON_DEV until we decide what JON version this is going to go in.

master http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=27109e402d86deb7804249b870e7c15de7263491
Author: Lukas Krejci <lkrejci>
Date:   Wed Jun 6 14:54:38 2012 +0200

    [BZ 802550] - rewording the docs on rhq.agent.plugins.child-discovery.delay-secs
    to better explain what it actually means.

Pushing back to ON_QA.

This seems to work as expected, only the documentation wording was not clear enough.

I created the bug 829350 for tracking of inclusion of the updated xml comments on the setting in JON 3.1.1 and bug 829355 for updating JON 3.1.0 docs with the more accurate wording.

Bulk closing of old issues in VERIFIED state.