Bug 802605
| Summary: | There is some reference to libra in stickshift and cartridge package. | ||
|---|---|---|---|
| Product: | OKD | Reporter: | Johnny Liu <jialiu> |
| Component: | Pod | Assignee: | Rob Millner <rmillner> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.x | CC: | mfisher, rmillner, rpenta |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-19 18:22:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Variable names and error message text should be a safe enough change. The logger tag (libra_httpd_start) may have complications outside of its related user story. Fixed some references from /usr/libexec/li to /usr/libexec/stickshift in commit 5ea18ad. (In reply to comment #1) > Variable names and error message text should be a safe enough change. > Agree, that is why I set priority to "medium". > The logger tag (libra_httpd_start) may have complications outside of its > related user story. Hmmm, about "libra_httpd_start" tag, Compared with logger tag in <li.repo>/stickshift/abstract/abstract/info/connection-hooks/publish-git-url, found it is using "stickshift_node_publish_git_url" logger tag, so I think the logger tag (libra_httpd_start) should be fixed, too. Commits f7757c9, ee38651, and bf5bc21 rename libra-proxy to stickshift-proxy. Verified this bug with devenv_1662, and PASS. [jialiu@Johnny-Laptop cartridges]$ find . | xargs grep -i 'libra' | grep -v spec | grep -v README | grep -v "#" | grep -v -i librar grep: ./jenkins-1.4/info/configuration/jenkins-pre-deploy/plugins/openshift.hpi: No such file or directory ./haproxy-1.4/info/bin/gear-scale-ctl.rb: -h|--host libra server host running broker ./haproxy-1.4/info/bin/remove-gear: -h|--host libra server host running broker ./haproxy-1.4/info/bin/add-gear: -h|--host libra server host running [jialiu@Johnny-Laptop stickshift]$ find . | xargs grep -i 'libra' | grep -v spec | grep -v README | grep -v "#" | grep -v -i librar ./broker/config/environments/test.rb: :user => "libra", |
Description of problem: In git repo, use grep command to find out some reference to libra in stickshift package. According to US1972, there should no reference to libra in stickshift and cartridge package. Version-Release number of selected component (if applicable): devenv_1659 How reproducible: Always Steps to Reproduce: 1. Git clone li git repo 2. cd to <li repo>/stickshift, run the following command to filter "li" and "libra" key strings. $ find . | xargs grep -i libra | grep -v spec | grep -v README | grep -v "#" <--snip--> ./abstract/abstract/info/connection-hooks/set-db-connection-info: echo "$0 $@" | logger -p local0.notice -t libra_httpd_start ./node/lib/stickshift-node/express/setup_pam_fs_limits.sh:DEFAULT_LIBRA_SKEL_DIR=$GEAR_SKEL_DIR ./node/lib/stickshift-node/express/setup_pam_fs_limits.sh:LIBRA_MOUNTPOINT=`get_terminal_mountpoint $stickshift_dir` ./node/lib/stickshift-node/express/setup_pam_fs_limits.sh:QUOTA_FILE=$( echo ${LIBRA_MOUNTPOINT}/aquota.user | tr -s /) ./node/lib/stickshift-node/express/teardown_pam_fs_limits.sh:DEFAULT_LIBRA_SKEL_DIR=$GEAR_SKEL_DIR ./node/lib/stickshift-node/express/teardown_pam_fs_limits.sh:LIBRA_MOUNTPOINT=`get_terminal_mountpoint $stickshift_dir` ./node/lib/stickshift-node/express/teardown_pam_fs_limits.sh:QUOTA_FILE=$( echo ${LIBRA_MOUNTPOINT}/aquota.user | tr -s /) ./node/misc/bin/ss-trap-user: syslog.syslog("Invalid repository: not in libra_root - %s: (%s)" % <--snip--> $ find . | xargs grep -i "/li/" | grep -v spec | grep -v README | grep -v "#" ./node/lib/stickshift-node/express/teardown_pam_fs_limits.sh:CART_DIR=/usr/libexec/li/cartridges 3. cd to <li repo>/cartridge, run the following command to filter "li" and "libra" key string. $ find . | xargs grep -i 'libra' | grep -v spec | grep -v README | grep -v "#" | grep -v -i librar <--snip--> ./haproxy-1.4/info/connection-hooks/set-db-connection-info: echo "$0 $@" | logger -p local0.notice -t libra_httpd_start <--snip--> Actual results: Find out some reference to "libra", "li", or "LIBRA". Expected results: There should no any reference to "libra", "li", or "LIBRA". Additional info: