| Summary: | dhclient does not correctly escape SSIDs - prevents suspend from working | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Strugnell <nstrug> | ||||||
| Component: | NetworkManager | Assignee: | Dan Williams <dcbw> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 16 | CC: | cdemills, dcbw, jklimes, jpopelka | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-03-26 12:36:51 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Created attachment 569631 [details]
suspend log demonstrating abort due to dhcpclient fail
Problem is that ESSID='JoikuSpot_Martin\'s h' or DEVICE=Auto_JoikuSpot_Martin's_h are not correct bash strings, while NAME="Auto JoikuSpot_Martin\'s h" is. So the problem is not in dhclient but in program/hands that introduced these ESSID and DEVICE lines. Ok, I'm reassigning this to NetworkManager as that's probably the cause of these wrong string variables definitions. (In reply to comment #2) > Problem is that > ESSID='JoikuSpot_Martin\'s h' > or > DEVICE=Auto_JoikuSpot_Martin's_h > are not correct bash strings, > while > NAME="Auto JoikuSpot_Martin\'s h" > is. > > So the problem is not in dhclient but in program/hands that introduced > these ESSID and DEVICE lines. Yeah, the ESSID and DEVICE are not placed in double quotes, that results in bash failing on the file. However, NetworkManager *does* put the string in double quotes when it contains an apostrophe (or other special characters). So, the ifcfg file from the Description was probably modified manually. Closing as not a bug. Feel free to reopen if NM (nm-connection-editor) creates invalid ifcfg-* files. (In reply to comment #4) > However, NetworkManager *does* put the string in double quotes when it > contains an apostrophe (or other special characters). So, the ifcfg file > from the Description was probably modified manually. Seems that system-config-network was the culprit, see bug #846081. *** This bug has been marked as a duplicate of bug 846081 *** *** Bug 848089 has been marked as a duplicate of this bug. *** |
Created attachment 569629 [details] ifcfg that triggers the error Description of problem: /usr/lib64/pm-utils/sleep.d/56dhclient fails on SSIDs that contain an apostrophe. This results in suspend and hibernate aborting. Version-Release number of selected component (if applicable): dhclient-4.2.3-6.P2.fc16.x86_64 How reproducible: Always Steps to Reproduce: 1. cp attached ifcfg file to /etc/sysconfig/network-scripts 2. Select suspend from user menu 3. Actual results: Screensaver activates but machine does not suspend. Inspection of /var/log/pm-suspend.log shows that 56dhclient returned an exit status of 2, causing suspend to abort. Further investigation shows that dhclient barfed on the ifcfg containing the SSID "Auto JoikuSpot_Martin\'s h" Expected results: suspend shoud work! Additional info: