Bug 802810
| Summary: | as7: signal a reload-required to the user | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Libor Zoubek <lzoubek> | ||||
| Component: | Agent | Assignee: | Heiko W. Rupp <hrupp> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 4.3 | CC: | hrupp, mazz, theute | ||||
| Target Milestone: | --- | ||||||
| Target Release: | RHQ 4.5.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 820623 (view as bug list) | Environment: | |||||
| Last Closed: | 2013-09-01 10:01:51 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 707223, 820623 | ||||||
| Attachments: |
|
||||||
Note: our <resource-configuration> metadata can also indicate a restart is required. So we have the ability for any plugin to indicate a config change requires a restart: <simple-property ... activationPolicy="immediate"> where activationPolicy's default is "immediate" but which can be "restart" or "shutdown" (meaning, a change to that property will take effect either "immediately" or which requires a restart - I have no idea what it means for a config property to take effect "on shutdown" :-) I'm currently of the opinion the infrastructure changes required for this are out of scope for jon3.1, so setting priority to low. We could certainly add activationPolicy="restart" attributes on properties we know will need this support in the future. In the meantime we should include in the description of such properties a statement saying how a server restart is required in order for a value change to get picked up. Created attachment 578935 [details]
Possible patch
The attached patch uses the existing, but so far unused notes filed of configuration objects.
If a note is present, it will be shown in the config details view as transient yellow bar.
It would be nice if this could also be done in the history list, as this is where the user is directed after submitting a config change.
Upping priority given usability enhancement this could provide. master b303055 reverted in commit 3c58c86 master ac1d68bd117 verified on Version: 4.4.0.JON310-SNAPSHOT Build Number: 31b4844 puttning back ON_QA - need to verify on master Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since. |
Description of problem:Currently AS7 retunrs "response-headers" => {"process-state" => "reload-required"} in response to any configuration change that requires server restart. User needs to know this, because otherwise he expects his changes happen immediately. Version-Release number of selected component (if applicable): How reproducible:always Steps to Reproduce: 1.Make a config change that requires server restart using JON - for example change some configuration in 'standart-sockets' socket binding group Actual results: User does not know, whether configuration change you did is immediate or not. Expected results:User is notified about the fact, that server needs reload.