| Summary: | Review Request: drupal6-votingapi - Voting API module for Drupal6 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wesley Hearn <whearn> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, rdieter, shawn |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-19 11:58:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Wesley Hearn
2012-03-13 16:38:42 UTC
I'll take a gander. Found that the wrong LICENSE.txt was included I have updated it to include the correct one. SPEC: http://jknife.fedorapeople.org/SPECS/drupal6-votingapi.spec SRPM: http://jknife.fedorapeople.org/SRPMS/drupal6-votingapi-2.3-4.el6.src.rpm $ rpmlint *.rpm noarch/*.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Sources: ok
$ md5sum *.gz
d448a23d95204b05a927067d0aa4a704 votingapi-6.x-2.3.tar.gz
Naming: ok
macros: ok
scriptlets: n/a
Licenses: NOT ok
seems the tarball includes a copy of LICENSE.txt which is standard GPLv2, and I can't find mention of any "or later" clause to justify GPLv2+
SHOULD consider using a simpler approach for handling
Source1: %{name}-fedora-README.txt
and drop the relevant existing %build and %files %exclude snippets, and just use:
%files
%doc %{SOURCE1}
The rest of it is an *very* simple noarch package, though there seems to be some unused drupal macro boilerplate, which you could trim too.
Otherwise, remaining issue is licensing per my comment above.
Ok, I removed the added LICENSE.txt from the SRPM and I am using the one inside the tarball. I have also updated License from GPLv2+ to GPLv2. SPEC: http://jknife.fedorapeople.org/SPECS/drupal6-votingapi.spec SRPM: http://jknife.fedorapeople.org/SRPMS/drupal6-votingapi-2.3-4.el6.src.rpm the links you provide seem to be the same as from comment #2 still. ?? Sorry about that SPEC: http://jknife.fedorapeople.org/SPECS/drupal6-votingapi.spec SRPM: http://jknife.fedorapeople.org/SRPMS/drupal6-votingapi-2.3-5.el6.src.rpm win, APPROVED. New Package SCM Request ======================= Package Name: drupal6-votingapi Short Description: Voting API module for Drupal6 Owners: jknife Branches: f16 el6 InitialCC: Git done (by process-git-requests). $ koji latest-pkg f16-updates drupal6-votingapi Build Tag Built by ---------------------------------------- -------------------- ---------------- drupal6-votingapi-2.3-5.fc16 f16-updates jknife looks like the deed is done, closing. Package Change Request ====================== Package Name: drupal6-votingapi New Branches: f17 Owners: jknife InitialCC: Guess I submitted the request after Fedora 17 had been split off. Git done (by process-git-requests). Package Change Request ====================== Package Name: drupal6-votingapi New Branches: el5 Owners: jknife siwinski InitialCC: Adding el5 branch to follow most other drupal6 packages. Git done (by process-git-requests). |