Bug 804187
Summary: | USB dialog should provide some help when no device available. | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Marc-Andre Lureau <marcandre.lureau> |
Component: | spice-gtk | Assignee: | Christophe Fergeau <cfergeau> |
Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 6.3 | CC: | acathrow, cfergeau, dblechte, dyasny, gkong, hdegoede, jwu, mbarta, mkrcmari, mzhan, rwu, yupzhang, zpeng |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | spice-gtk-0.14-4.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-21 08:47:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marc-Andre Lureau
2012-03-16 19:06:25 UTC
This request was not resolved in time for the current release. Red Hat invites you to ask your support representative to propose this request, if still desired, for consideration in the next release of Red Hat Enterprise Linux. This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development. This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4. The guts of the USB device selection dialog are provided by the following function spice_usb_device_widget_new this is part of the spice-client-gtk library Fix pushed upstream http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=0ede57e56b84fba4db2f3578541ce3e0eb06bcb3 Tested on spice-gtk-0.14-3.el6.x86_64 containing the fix from comment 7. When the USB device selection dialog window from remote-viewer connected to a VM is invocated, there are no USB devices listed for redirection even though they are physically present. Only the newly provided message saying "No USB devices detected" is shown. (In reply to comment #9) > Tested on spice-gtk-0.14-3.el6.x86_64 containing the fix from comment 7. > > When the USB device selection dialog window from remote-viewer connected to > a VM is invocated, there are no USB devices listed for redirection even > though they are physically present. > Only the newly provided message saying "No USB devices detected" is shown. That looks like a different bug then. The original bug I reported is that there was no help message, and now there is one. If your device is not listed, there might be several reasons. What USB device is it? When did you plug the device? Ok, there is the help message now. But the problem is the message is there no matter what USB device is connected. My lsusb: Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 001 Device 002: ID 8087:0020 Intel Corp. Integrated Rate Matching Hub Bus 002 Device 002: ID 8087:0020 Intel Corp. Integrated Rate Matching Hub Bus 001 Device 003: ID 0a5c:217f Broadcom Corp. Bluetooth Controller Bus 001 Device 004: ID 17ef:100a Lenovo ThinkPad Mini Dock Plus Series 3 Bus 001 Device 005: ID 17ef:480f Lenovo Integrated Webcam [R5U877] Bus 001 Device 006: ID 046d:c069 Logitech, Inc. M500 Laser Mouse Bus 001 Device 007: ID 046a:0011 Cherry GmbH G83 (RS 6000) Keyboard Bus 002 Device 004: ID 13fe:3100 Kingston Technology Company Inc. 2/4 GB stick None of theese devices are listed in the dialog. Only the "No USB devices detected" message is shown there. Auto redirection works fine, the plugged device gets connected and still doesn't show up in the USB device dialog. The patch also contains the corresponding git commit log which can be found at http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=0ede57e56b84fba4db2f3578541ce3e0eb06bcb3 Among other things, it contains this: "This can be tested with diff --git a/gtk/usb-device-widget.c b/gtk/usb-device-widget.c index b1bf090..660ea03 100644 --- a/gtk/usb-device-widget.c +++ b/gtk/usb-device-widget.c @@ -220,6 +220,11 @@ static GObject *spice_usb_device_widget_constructor( G_CALLBACK(device_error_cb), self); devices = spice_usb_device_manager_get_devices(priv->manager); + if (devices) { + g_ptr_array_unref(devices); + devices = NULL; + } + if (!devices) goto end;" and it seems the %patch command in the .spec picked this part of the .patch as if this was something to apply rather than just some comment... I've observed this when running rhpkg prep, and having this hunk in the build explains what you are seeing. Pushed a new build which should address this issue. *** Bug 868106 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0343.html |