Bug 804484
Summary: | [abrt] libcdio-0.82-5.fc16: __GI___libc_free: Process /usr/bin/cd-info was killed by signal 11 (SIGSEGV) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Stuart D Gathman <stuart> | ||||||
Component: | libcdio | Assignee: | Adrian Reber <adrian> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 16 | CC: | adrian, david.vangaal, hhorak | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | i686 | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | abrt_hash:14a8f5a97fae1ce4a1d407b74333adcb2c11f3aa | ||||||||
Fixed In Version: | libcdio-0.83-3.fc17 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2012-04-08 03:33:57 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Stuart D Gathman
2012-03-19 03:49:13 UTC
Created attachment 570995 [details]
File: backtrace
As discovered in bug#802070, this happens on CDs with 99 tracks (typically audiobooks). Thanks for the report. I contacted upstream to see if they know anything about it. In cdtext.c cdtext_data_init(), i_track gets up to 103 before crashing, and there are only 99 tracks. I tried adding "if (i_track > 99) break;" - but it still crashes. Getting new backtrace. Created attachment 571581 [details]
Patch that fixes the symptom
This fixes the symptom, but why does the loop not terminate normally? Is 99 a hard limit?
*** Bug 802070 has been marked as a duplicate of this bug. *** The specification doesn't seem to be open. I'm guessing that a) there is a hard limit of 99 tracks, and it was felt there was no need to terminate the 99th track. My patch would actually be correct in this case. b) cdtext_data_init needs to break the loop when reaching the end of the block rather than relying on termination. This is a good idea anyway in case of malicious or broken data in the cdtext area. Provided patch may be sufficient while waiting for upstream. Thanks for the patch. I will apply it. Following answer from upstream: """ Thanks for the report. I just had a chance to look at. Yes, this is a bug in current sources. Red Book standards limit the number of tracks to 99. See for example item 3 of http://en.wikipedia.org/wiki/Red_Book_(CD_standard)#Technical_details I've recompiled the code to lower the track limit to 9 tracks and I get a memory violation using valgrind in freeing memory similar to one of the reports. I will be changing the code along the lines of the patches I see in the reports but slightly differently to ensure this is covered more pervasively and to warn when there is a violation. """ libcdio-0.83-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libcdio-0.83-3.fc17 libcdio-0.82-6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libcdio-0.82-6.fc16 Package libcdio-0.83-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing libcdio-0.83-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-4558/libcdio-0.83-3.fc17 then log in and leave karma (feedback). Works for me, and I tried the 99 track CD that was failing before. Left karma. libcdio-0.82-6.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. libcdio-0.83-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |