Bug 804668

Summary:	NETCF: debian driver doesn't compile because NETCF_TRANSACTION is undefined
Product:	[Community] Virtualization Tools	Reporter:	Hendrik Schwartke <hendrik>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	crobinso, ralf, xen-maint
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:	Ubuntu precise
Last Closed:	2016-03-23 20:56:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Hendrik Schwartke 2012-03-19 14:50:27 UTC

Description of problem:
"configure && make" ends with the following error:
drv_debian.c: In function 'drv_change_begin':
drv_debian.c:1078:15: error: 'NETCF_TRANSACTION' undeclared (first use in this function)
drv_debian.c:1078:15: note: each undeclared identifier is reported only once for each function it appears in
drv_debian.c: In function 'drv_change_rollback':
drv_debian.c:1091:15: error: 'NETCF_TRANSACTION' undeclared (first use in this function)
drv_debian.c: In function 'drv_change_commit':
drv_debian.c:1104:15: error: 'NETCF_TRANSACTION' undeclared (first use in this function)

netcf commit: d340f2dfcd6461c9743dccdabe3b610f5fbc8fe8

The macro for the debian driver is neither defined in configure.ac (like for the redhat driver) nor defined statically (like for the suse driver).

Comment 1 Cole Robinson 2016-03-23 20:56:15 UTC

I think this was fixed by:

commit f3aa52772c7dc123524dca1cdb0986f77e89b70e
Author: Serge Hallyn <serge.hallyn>
Date:   Sat Apr 28 01:24:11 2012 +0000

    define NETCF_TRANSACTION as false in debian