| Summary: | rpmdiff: Improper patch call in specfile | ||
|---|---|---|---|
| Product: | [Retired] CloudForms Common | Reporter: | Jay Turner <jturner> |
| Component: | rubygem-sqlite3 | Assignee: | John Eckersberg <jeckersb> |
| Status: | CLOSED ERRATA | QA Contact: | Og Maciel <omaciel> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 1.0.0 | CC: | ckannan, cpelland, dmacpher, jeckersb, jomara, mmccune, morazi, omaciel, srevivo |
| Target Milestone: | beta2 | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-sqlite3-1.3.3-8.el6cf | Doc Type: | Bug Fix |
| Doc Text: |
rubygem-sqlite3 contained a non-standard packaging format for a patch. This bug fix corrects the packaging format.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-04 14:59:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
closing, WONTFIX, removing from ce/se/sam tag I'm back! rubygem-sqlite3 got pulled back into the mix late in the game so this package is indeed shipping again. Instead of just fixing it the first time around so the packaging would be correct for anyone else that picked up the package, the lazy road was taken and now we're forced to ship non-compliant packaging in a GA product. Flagging against 1.0.z. QE ack to blocker for 1.0.z. Note to self so I don't forget this over the weekend...
The offending patch command is happening in the %check section, but the %patch macro only works in the %prep section. Because of this, in the %prep section, we'll need to:
- unpack %{SOURCE0}
- patch it with the %patch macro
And then in the %build section instead of just gem installing %{SOURCE0}...
- rebuild the .gem from the unpacked, patched source
- gem install the resultant .gem file.
Something like: http://fedoraproject.org/wiki/Packaging:Ruby#Building_gems
tested with rubygem-sqlite3-1.3.3-9.el6cf.src.rpm
verified.
.live.[root@qe-blade-01 SPECS]# grep -i patch0 rubygem-sqlite3.spec
Patch0: %{name}-1.3.3-big-endian.patch
%patch0
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-1516.html |
Description of problem: Specfile includes: 'patch -l -p0 < %{PATCH0}' which is not standard Red Hat packaging format. Should simply be: %patch0 (salt to taste). Version-Release number of selected component (if applicable): 1.3.3-6.el6 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: