Bug 805187

Summary: Resource error detail view should omit non-end-user relevant content
Product: [Other] RHQ Project Reporter: Heiko W. Rupp <hrupp>
Component: Core UIAssignee: RHQ Project Maintainer <rhq-maint>
Status: NEW --- QA Contact: Mike Foley <mfoley>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 4.3CC: hrupp
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
screen shot 1
none
screen shot 2 none

Description Heiko W. Rupp 2012-03-20 12:17:42 EDT
Created attachment 571465 [details]
screen shot 1

I have a resource error. When I click on the message center I see 

org.rhq.core.pluginapi.inventory.InvalidPluginConfigurationException: Failed to start component for resource Resource[id=16949, uuid=6fc270b3-c840-486a-8716-f402643c7110, type={jboss-as-7}Datasources, key=subsystem=datasources, name=datasources, parent=EAP pintsize].


(screenshot 1) - this has so much information that the user does not want to see (e.g. uuid). Or perhaps even that this is a InvalidPCException


Clicking on the row shows: (screenshot 2)

---------
org.rhq.core.pluginapi.inventory.InvalidPluginConfigurationException: Failed to start component for resource Resource[id=16949, uuid=6fc270b3-c840-486a-8716-f402643c7110, type={jboss-as-7}Datasources, key=subsystem=datasources, name=datasources, parent=EAP pintsize].
	at org.rhq.core.pc.inventory.InventoryManager.activateResource(InventoryManager.java:1682)
	at org.rhq.core.pc.inventory.InventoryManager.refreshResourceComponentState(InventoryManager.java:2886)
	at org.rhq.core.pc.inventory.InventoryManager.processSyncInfo(InventoryManager.java:2639)
	at org.rhq.core.pc.inventory.InventoryManager.processSyncInfo(InventoryManager.java:2645)
	at org.rhq.core.pc.inventory.InventoryManager.processSyncInfo(InventoryManager.java:2645)
	at org.rhq.core.pc.inventory.InventoryManager.synchInventory(InventoryManager.java:1081)
	at org.rhq.core.pc.inventory.InventoryManager.handleReport(InventoryManager.java:1055)
	at org.rhq.core.pc.inventory.AutoDiscoveryExecutor.call(AutoDiscoveryExecutor.java:131)
	at org.rhq.core.pc.inventory.AutoDiscoveryExecutor.run(AutoDiscoveryExecutor.java:93)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:165)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:636)
Caused by: org.rhq.core.pluginapi.inventory.InvalidPluginConfigurationException: Connected server is in standalone mode, but discovery saidorg.rhq.modules.plugins.jbossas7.DatasourceComponent
	at org.rhq.modules.plugins.jbossas7.BaseComponent.checkState(BaseComponent.java:154)
	at org.rhq.modules.plugins.jbossas7.BaseComponent.start(BaseComponent.java:135)
	at sun.reflect.GeneratedMethodAccessor35.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:616)
	at org.rhq.core.pc.inventory.ResourceContainer$ComponentInvocationThread.call(ResourceContainer.java:601)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	... 3 more
-------------

Here the first stack trace between "org.rhq.core.pluginapi.inventory.InvalidPluginConfigurationException: Faile.." and "Caused by" is totally useless to the user. This is completely internal stuff.
Also for the real cause, only the plugin part of the stack trace *may* be interesting - the part below
"at org.rhq.modules.plugin" is non-interesting again.

Even more - if you look at screen shot 2, you see that the real interesting part of the message , the "Connected server is in standalone mode, but discovery saidor..." part is not directly visible on screen and the user has the first scroll around to find out what is actually going on.
Comment 1 Heiko W. Rupp 2012-03-20 12:18:18 EDT
Created attachment 571466 [details]
screen shot 2
Comment 2 Heiko W. Rupp 2012-03-20 12:21:02 EDT
In earlier RHQ the error box had a "show stack trace" button, so by default only e.g. the cause message was displayed and when you clicked on "show stack trace" you got the technical crap
Comment 3 Mike Foley 2012-03-26 11:57:34 EDT
medium, no target release 

per bz triage (crouch, mfoley, asantos, loleary)