Bug 806386
| Summary: | Uninitialized return value in 'sudo' package. | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Pavel Raiskup <praiskup> |
| Component: | sudo | Assignee: | Daniel Kopeček <dkopecek> |
| Status: | CLOSED ERRATA | QA Contact: | BaseOS QE Security Team <qe-baseos-security> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.3 | CC: | amarecek, dapospis, pvrabec |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | sudo-1.7.4p5-9.el6 | Doc Type: | Bug Fix |
| Doc Text: |
No documentation needed.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-20 14:22:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Thanks for the report. This needs to be fixed.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
No documentation needed.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2012-0905.html Setting qe_test_coverage‑. This is covered by Coverity scan. |
New Coverity scan has found one new potential defect in 'sudo.1.7.4p5-8' against 'sudo-1.7.4p5-7.el6': Returning of uninitialized variable 'j' on sudo_edit.c:343. It seems there was a try to initialize this variable in the source, but on a bad position -- proposed fix could look like this: | --- a/sudo_edit.c | +++ b/sudo_edit.c | @@ -335,9 +335,9 @@ | warningx("contents of edit session left in %s", tf[i].tfile); | } | close(ofd); | - | - j = 0; | } | + | + j = 0; | } | | return j; .. or maybe better approach, initialize it on the top of the function. This potential problem was added by sudo-1.7.4p5-sudoedit-selinux.patch. This error is mentioned just as a warning and it depends on you whether it will be fixed or not. Feel free to move this bug to 6.4 if you think it is not necessary to fix it in 6.3 or close it as a NOTABUG if we don't need to fix it at all. We are able to re-run Coverity for verifying potential fixes.