Bug 806473

Summary:	rhc-admin-move doesn't respect the -t option
Product:	OKD	Reporter:	Thomas Wiest <twiest>
Component:	Containers	Assignee:	Dan McPherson <dmcphers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	jialiu, rmillner
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	devenv_1672	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-13 18:30:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Thomas Wiest 2012-03-23 21:30:44 UTC

Description of problem:
While doing moves, we had one move that took a long time to run chcon / restorecon because it had many, many files.

It took so long that the move would time out and fail, even though there was no problem at all.

While working with Dan, we tried specifying -t, but that didn't help. We even tried upping the timeout value in the broker's production.rb file to over 60 seconds (from 120 to 240). This also had no affect.

Every time, the move would time out right at 60 seconds (we could see this in the mcollective log file of the destination node).


Version-Release number of selected component (if applicable):
2.0.6, not sure what RPM versions.


How reproducible:
With the right app, very. The app has to have a ton of files so that the move takes longer than 60 seconds.


Steps to Reproduce:
1. Move an app that takes more than 60 seconds
2. Notice that the move fails at exactly 60 seconds.
3. Specify a -t of 120 seconds.
4. Notice that it had no effect and that the move still failed after 60 seconds.
  

Actual results:
The move times out at 60 seconds no matter what.


Expected results:
The -t option to rhc-admin-move should be able to determine how long before the move times out.

Comment 1 Dan McPherson 2012-03-25 02:37:31 UTC

Note that the -n param is now -a

The max time is now set to 240 secs.  We can increase if needed.

Comment 2 Johnny Liu 2012-03-28 08:27:55 UTC

Verified this bug with devenv_1677, and PASS.

1. Create 30000 file in app
2. Log into instance run rhc-admin-move successfully without timeout
3. Run rhc-admin-move successfully with timeout (5)
Now it failed.

######################## Body End ############################
DEBUG: Stopping existing app 'phptest' before moving
DEBUG: Force stopping existing app 'phptest' before moving
DEBUG: Reserved uid '' on district: 'NONE'
DEBUG: Creating new account for app 'phptest' on ip-10-224-109-199
DEBUG: Moving content for app 'phptest' to ip-10-224-109-199
Identity added: /var/www/stickshift/broker/config/keys/rsync_id_rsa (/var/www/stickshift/broker/config/keys/rsync_id_rsa)
Agent pid 16936
DEBUG: Performing cartridge level move for 'phptest' on ip-10-224-109-199
DEBUG: Moving failed.  Rolling back 'phptest' with remove-httpd-proxy on 'ip-10-224-109-199'
DEBUG: Moving failed.  Rolling back 'phptest' with destroy on 'ip-10-224-109-199'
URL: http://phptest-jialiu.dev.rhcloud.com
/var/www/stickshift/broker/lib/express/broker/application_container_proxy.rb:745:in `parse_result': Node execution failure (error getting result from node).  If the problem persists please contact Red Hat support. (StickShift::NodeException)
	from /var/www/stickshift/broker/lib/express/broker/application_container_proxy.rb:129:in `destroy'
	from /var/www/stickshift/broker/lib/express/broker/application_container_proxy.rb:540:in `move_app'
	from /usr/bin/rhc-admin-move:114


So timeout take effect now.