| Summary: | Review Request: php-channel-phpdoc - Adds phpdoc channel to PEAR | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christof Damian <christof> | ||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-06-03 23:26:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Christof Damian
2012-03-24 15:24:51 UTC
Please - remove php-cli from requires - change license to Public Domain - clean unneeded macros (rm, install, mkdir) (In reply to comment #1) > Please > - remove php-cli from requires > - change license to Public Domain > - clean unneeded macros (rm, install, mkdir) Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-2.fc16.src.rpm new version with fixes. Created attachment 585871 [details]
review.txt
Report from fedora-review 0.1.3
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/extras/SPECS/review/806542/channel.xml :
MD5SUM this package : 9a98bf7cb7f1283d66d72b67a60db274
MD5SUM upstream package : 0b849ebcb14fcb60f70b0fa66f4c65fa
Please fix the channel.xml (you provide the one from pear.phpqatools.org)
(In reply to comment #4) > [!]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > /home/extras/SPECS/review/806542/channel.xml : > MD5SUM this package : 9a98bf7cb7f1283d66d72b67a60db274 > MD5SUM upstream package : 0b849ebcb14fcb60f70b0fa66f4c65fa > > Please fix the channel.xml (you provide the one from pear.phpqatools.org) Sorry, no idea how that happened. I thought I checked it. Here is a new one: Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-3.fc16.src.rpm MD5SUM this package : 0b849ebcb14fcb60f70b0fa66f4c65fa MD5SUM this package : 0b849ebcb14fcb60f70b0fa66f4c65fa APPROVED (In reply to comment #6) > MD5SUM this package : 0b849ebcb14fcb60f70b0fa66f4c65fa > MD5SUM this package : 0b849ebcb14fcb60f70b0fa66f4c65fa > > > APPROVED cheers New Package SCM Request ======================= Package Name: php-channel-phpdoc Short Description: Adds phpdoc channel to PEAR Owners: cdamian Branches: f17 f16 el6 InitialCC: Git done (by process-git-requests). php-channel-phpdoc-1.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-channel-phpdoc-1.3-3.fc17 php-channel-phpdoc-1.3-3.fc17 has been pushed to the Fedora 17 testing repository. php-channel-phpdoc-1.3-3.fc17 has been pushed to the Fedora 17 stable repository. |