Bug 806594

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.

rpmlint python-django-notification-0.2-1.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint python-django-notification-0.2-1.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/misc/checkout/git/FedoraReview/src/806594/django-notification-0.2.tar.gz :
  MD5SUM this package     : 0ba8e2ef23e1bcd1bc83e508d7580782
  MD5SUM upstream package : 0ba8e2ef23e1bcd1bc83e508d7580782

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.


==== Python ====
[x]: MUST Module list python2-devel or python3-devel as BuildRequires
[x]: MUST Python egg is built from source



Generated by fedora-review 0.2.0git
External plugins:


$ rpmlint python-django-notification-0.2-1.fc18.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint python-django-notification-0.2-1.fc17.src.rpm        
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

No warning, nothing to change, so the package is good to go.

You forgot the obsoletes of the old package.

oopsie, good catch.

Updated SPEC: http://www.matthias-runge.de/fedora/python-django-notification.spec
Updated SRPM: http://www.matthias-runge.de/fedora/python-django-notification-0.2-2.fc16.src.rpm

@@ -3,7 +3,7 @@
 
 Name:           python-django-notification
 Version:        0.2
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        User notification management for the Django web framework
 
 Group:          Development/Languages
@@ -16,6 +16,10 @@
 BuildRequires:  python-setuptools
 Requires:       python-django
 
+Provides:       %{pkgname} = %{version}-%{release}
+# latest release for django-notification is 0.1.2-6
+Obsoletes:      %{pkgname} < %{obs_ver}
+
 %description
 Many sites need to notify users when certain events have occurred and to
 allow configurable options as to how those notifications are to be received.
@@ -46,6 +50,9 @@
 %{python_sitelib}/django_notification-%{version}-py?.?.egg-info
 
 %changelog
+* Mon Mar 26 2012 Matthias Runge <mrunge> - 0.2-2
+- obsolete old package
+
 * Sat Mar 24 2012 Matthias Runge <mrunge> - 0.2-1
 - package renamed to python-django-notification
 - update to version 0.2

So with this addition, the package is good to be sent.

Thanks for your review!

New Package SCM Request
=======================
Package Name: python-django-notification
Short Description: User notification management for the Django web framework
Owners: mrunge
Branches: devel

Git done (by process-git-requests).

imported, built, django-notification retired, request for blocking
https://fedorahosted.org/rel-eng/ticket/5147

Package Change Request
======================
Package Name: python-django-notification
New Branches: el6
Owners: mrunge

Git done (by process-git-requests).