Bug 806689

Summary: xfig is unable to open (encapsulated) postscript files
Product: Red Hat Enterprise Linux 6 Reporter: Rohan Ferris <rferris>
Component: xfigAssignee: Stanislav Ochotnicky <sochotni>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: ddumas, mnapolis, syeghiay, tpelka
Target Milestone: rcKeywords: Patch, Regression, Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: xfig-3.2.5-23.a.el6 Doc Type: Bug Fix
Doc Text:
Cause Security errata RHSA-2012:0095 changed the way ghostscript handles relative paths. Consequence Xfig relies on old ghostscript behaviour and because of this fails to open encapsulated postscript files and instead shows an error. Fix Xfig was changed to use absolute paths when executing ghostscript binary Result Xfig is able to open encapsulated postscript files and include them in other figures.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 15:14:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 646086    
Bug Blocks:    
Attachments:
Description Flags
.fig file which will reproduce the problem.
none
Patch to rectify issue reading eps files
none
Screenshot of issue occurring none

Description Rohan Ferris 2012-03-26 01:28:03 UTC 
This has already been fixed in https://bugzilla.redhat.com/show_bug.cgi?id=657290

Description of problem:
When you include an EPS file in an xfig figure, ghostscript gets called but
produces an error, and no figure is included. The same is true if you open a
.fig file that has an EPS embedded.

Version-Release number of selected component (if applicable):
xfig-3.2.5-23.b.el6.x86_64

How reproducible:

Steps to Reproduce:
1. Start xfig
2. click on the picture icon
3. browse to an EPS file

Actual results:
ERROR from ghostscript: Error: /invalidfileaccess in --run-- Operand stack: 3
--nostringval-- (p1814a.ps) (r) Execution stack: %interp_exit .runexec2
--nostringval-- --nostringval-- --nostringval-- . . . . GPL Ghostscript 8.71:
Unrecoverable error, exit code 1 EPS object read OK, but no preview bitmap
found/generated

Xfig continures, but the EPS is not showing up.

Expected results:
Figure displaying with the EPS file in it.
Comment 3 Stanislav Ochotnicky 2012-04-04 11:58:30 UTC 
No such build has ever existed and I cannot reproduce with latest version in 6.2 (which is xfig-3.2.5-22.a.1.el6). Closing, but if you can reproduce with latest official build feel free to reopen.
Comment 4 Rohan Ferris 2012-04-04 22:15:40 UTC 
Created attachment 575229 [details]
.fig file which will reproduce the problem.

This figure contains an encapsulated postscript file. When opened it will cause xfig to crash.
Comment 5 Rohan Ferris 2012-04-04 22:16:47 UTC 
Reopening bug, as I can confirm issue exists with latest package version. I am uploading the patch that fixes the issue.
Comment 6 Rohan Ferris 2012-04-04 22:19:28 UTC 
Created attachment 575230 [details]
Patch to rectify issue reading eps files

Uploaded xfig-3.2.5b-fix-eps-reading.patch which I have tested and can confirm as fixing the issue.
Comment 7 Stanislav Ochotnicky 2012-04-05 08:01:15 UTC 
Attached file contains just the fig file, but the eps is actually not there just linked from it. That's how xfig handles eps files inside figures. Even if I provide some eps file, xfig is still able to open it without problems and I cannot reproduce. Can you perhaps make a tarball with:
 * reproducer.fig
 * circle.eps

Also:
> This figure contains an encapsulated postscript file. When opened it will cause
> xfig to crash.

Original report was about ghostscript producing an error which would suggest the problem is actually the eps file and/or ghostscript. Plus there was no mention of xfig crashing. That would be a different bug probably.

Please include at least circle.eps, otherwise I can't reproduce
Comment 8 Rohan Ferris 2012-04-06 05:01:46 UTC 
Created attachment 575610 [details]
eps file which causes error message

I have attached circle.eps. Apologies for previous mis-inclusion before. This file when trying to add as a picture to an xfig document causes an error message to be displayed. The application does not crash, but is unable to show the embedded file.
Comment 9 Stanislav Ochotnicky 2012-04-06 07:53:00 UTC 
As weird as this sounds I still cannot reproduce. Can you walk me through it? I would like to exactly replicate your steps. I am especially interested in:
 * placement of files on filesystem
 * current directory when you run xfig

Also, just to be sure, output of:
$ rpm -q ghostscript xfig
Comment 10 Rohan Ferris 2012-04-07 05:17:19 UTC 
Created attachment 575868 [details]
Screenshot of issue occurring

Steps for reproducing:

1. Open xfig
2. Select Picture (the camera button)
3. draw the selection area
4. select browse
5. choose circle.eps

# rpm -q ghostscript xfig
ghostscript-8.70-11.el6_2.6.x86_64
xfig-3.2.5-22.a.1.el6.x86_64
Comment 18 Stanislav Ochotnicky 2012-04-17 09:54:42 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
    Security errata RHSA-2012:0095 changed the way ghostscript handles relative paths.

Consequence
    Xfig relies on old ghostscript behaviour and because of this fails to open encapsulated postscript files and instead shows an error. 
Fix
    Xfig was changed to use absolute paths when executing ghostscript binary
Result
    Xfig is able to open encapsulated postscript files and include them in other figures.
Comment 20 errata-xmlrpc 2012-06-20 15:14:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0985.html