Bug 80670
| Summary: | bad source code | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | d.binderman |
| Component: | gimp | Assignee: | Nils Philippsen <nphilipp> |
| Status: | CLOSED UPSTREAM | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8.0 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-02-21 17:21:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This is stuff for upstream really. 8.0 is end-of-life also. Re-assign so replies reach me. Re-assign so replies reach me. |
From Bugzilla Helper: User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk (Win98; I) Description of problem: Hello there, I have just tried to compile package gimp-1.2.3-9 from Redhat 8.0 I got the following message from the compiler. cc: Warning: imap_preview.c, line 167: In the initializer for avg, the expression "(299**colour+++587**colour+++114**colour++)/1000" modifies the variable "colour" more than once without an intervening sequence point. This behavior is undefined. (undefvarmod) Here is an untested patch to shut up the compiler. ./plug-ins/imagemap/imap_preview.c.old ./plug-ins/imagemap/imap_preview.c *** ./plug-ins/imagemap/imap_preview.c.old Sun Dec 15 09:25:53 2002 --- ./plug-ins/imagemap/imap_preview.c Sun Dec 15 09:26:34 2002 *************** *** 164,171 **** colour = cmap + 3 * (int)(*src); if (gray) { ! guchar avg = (299 * *colour++ + 587 * *colour++ + ! 114 * *colour++) / 1000; *dest++ = avg; *dest++ = avg; *dest++ = avg; --- 164,172 ---- colour = cmap + 3 * (int)(*src); if (gray) { ! guchar avg = (299 * colour[ 0] + 587 * colour[ 1] + ! 114 * colour[ 2]) / 1000; ! colour += 3; *dest++ = avg; *dest++ = avg; *dest++ = avg; Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. compile with Compaq compiler 2. 3. Additional info: compaq compiler is not significant. GNU Compiler could probably also produce this error message with -Wall.