Bug 806916

Summary: REST API: SetupNetworks missing action link
Product: Red Hat Enterprise Virtualization Manager Reporter: Avi Tal <atal>
Component: ovirt-engine-restapiAssignee: Michael Pasternak <mpastern>
Status: CLOSED CURRENTRELEASE QA Contact: Yaniv Kaul <ykaul>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.1.0CC: acathrow, bazulay, dyasny, ecohen, iheim, jkt, lpeer, mkolesni, mpastern, Rhev-m-bugs, sgrinber, srevivo, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: infra network
Fixed In Version: si17 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 20:02:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Avi Tal 2012-03-26 13:51:18 UTC
Description of problem:
htttp://engine:port/hosts/{host id}/nics/setupnetworks
This action link is missing under /nics

Exists:
<host_nics>
    <host_nic>
        ...
    </host_nic>
    <host_nic>
        ...
    </host_nic>
</host_nics>

--
should look like:
<host_nics>
    <actions>
        <link href='.../nics/setupnetworks' rel='setupnetworks' />
    </actions>
    <host_nic>
        ...
    </host_nic>
    <host_nic>
        ...
    </host_nic>
</host_nics>

Comment 4 Avi Tal 2012-07-26 09:45:16 UTC
Adding TesBlocker because it actually blocked us from testing SetupNetworks in automation framework.
Automation framework automatically generated data structures from XSD.
Missing actions for nics collection leads for missing SetupNEtworks action for nics data structure object.

BTW, the common use cases in automation is to automatically generate objects from XSD so i suspect many API users will scream this issue.

Comment 6 Ori Liel 2012-08-01 13:02:54 UTC
patch posted to gerrit, http://gerrit.ovirt.org/#/c/6816/

Comment 7 Michael Pasternak 2012-08-23 09:40:27 UTC
lowering priority as action code exist - QE can assume the url [1], and sdk has setupnetworks() method, so no blocker for testing.

(this is complex infrastructure change that may take time)

[1] /api/hosts/xxx/nics/setupnetwork

Comment 8 Michael Pasternak 2012-08-23 15:40:44 UTC
patch is NACK'ED at upstream.

Comment 9 Michael Pasternak 2012-08-25 14:31:57 UTC
http://gerrit.ovirt.org/#/c/7461/

Comment 11 Avi Tal 2012-08-30 16:03:34 UTC
Verify on SI16 - PASS

<host_nics>
 <actions>
  <link href="/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/setupnetworks" rel="setupnetworks"/>
 </actions>
...

Comment 12 Avi Tal 2012-09-03 13:00:23 UTC
Reopen the bug due to missing entry point "/api"

href starts from "/hosts" instead of "/api/hosts" which lead to automation tests failure.

Comment 13 Avi Tal 2012-09-03 15:12:26 UTC
Wrong href example is in comment 11

Comment 15 Avi Tal 2012-09-05 13:38:00 UTC
Verify on si17 - PASS

<host_nics>
 <actions>
  <link href="/api/hosts/15bc90e8-f74d-11e1-a639-001a4a169763/nics/setupnetworks" rel="setupnetworks"/>
 </actions>
 ...