Bug 806963

Summary: Comment lines that exceed ~80 characters cause an error in parsing the config
Product: [Fedora] Fedora EPEL Reporter: George Notaras <gnot>
Component: xl2tpdAssignee: Paul Wouters <pwouters>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: el6CC: pwouters
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: xl2tpd-1.3.1-5.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-01 00:56:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch for reported bug none

Description George Notaras 2012-03-26 15:59:14 UTC 
Description of problem:
This is probably the weirdest bug I've come across in a while. It seems that if a comment, which is longer than ~80 characters, is added in xl2tpd.conf, then the configuration cannot be parsed. Errors printed in syslog are terrible as well:

Mar 26 08:16:36 centos xl2tpd[28687]: parse_config: line 15: no '=' in data
Mar 26 08:16:36 centos xl2tpd[28687]: init: Unable to load config file

Version-Release number of selected component (if applicable):
xl2tpd-1.3.1-1.el6.i686
Comment 1 Paul Wouters 2012-04-05 17:24:12 UTC 
Created attachment 575501 [details]
patch for reported bug
Comment 2 Paul Wouters 2012-04-05 17:24:54 UTC 
Thanks for the report. Patch attached. Currently it is building in rawhide, but I'll push udpates out for the other branches as well.
Comment 3 George Notaras 2012-04-19 19:50:43 UTC 
I had somehow missed this notification. Thank you for your work.

This bug was not really important or a bug at all, as long as that limitation about the configuration syntax had been known.

I cannot currently find an EPEL-6 rpm for xl2tpd-1.3.1-5. I'll download the source rpm from this[1] page, rebuild it and test it under centos 6 in the next days.

[1] http://koji.fedoraproject.org/koji/buildinfo?buildID=314049
Comment 4 Fedora Update System 2012-04-20 15:51:27 UTC 
xl2tpd-1.3.1-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/xl2tpd-1.3.1-5.fc16
Comment 5 Fedora Update System 2012-04-22 03:29:05 UTC 
Package xl2tpd-1.3.1-5.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xl2tpd-1.3.1-5.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-6372/xl2tpd-1.3.1-5.fc16
then log in and leave karma (feedback).
Comment 6 Fedora Update System 2012-05-01 00:56:10 UTC 
xl2tpd-1.3.1-5.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.