Bug 807113

Summary: Review Request: zanata-util - Helper scripts for using Zanata
Product: [Fedora] Fedora Reporter: Ding-Yi Chen <dchen>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: zanata-util-0.2.7-1.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-20 03:08:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ding-Yi Chen 2012-03-27 04:20:55 UTC
Spec URL: http://dchen.fedorapeople.org/files/rpms/zanata-util.spec
SRPM URL: http://dchen.fedorapeople.org/files/rpms/zanata-util-0.1.0-1.fc16.src.rpm
Description: 
zanata-util is a collection of helper scripts that make using Zanata easier.

It includes:
* zanata_pom_xml_make: Produce a pom.xml for using Zanata maven client.
     It either inserts setting for zanata plugin and zanata plugin repository,
     or create a new pom.xml if pom.xml does not yet exists.

* zanata_zanata_xml_make: Produce a zanata.xml for using Zanata clients.
     It downloads the corresponding zanata.xml and map the local locales to
     the ones that Zanata server supported.

* zanata_replace_string_with_file:
     Replace a string in a file with content of a file.

Comment 1 Parag AN(पराग) 2012-03-27 05:29:11 UTC
1) unable to find source tarball. See
$ wget https://fedorahosted.org/releases/z/a/zanata-util/zanata-util-0.1.0.tar.gz
--2012-03-27 10:49:13--  https://fedorahosted.org/releases/z/a/zanata-util/zanata-util-0.1.0.tar.gz
Resolving fedorahosted.org... 66.135.62.191
Connecting to fedorahosted.org|66.135.62.191|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2012-03-27 10:49:14 ERROR 404: Not Found.


2) you don't need to write each perl package Requires: explicitly. They will get created automatically.

3) Is this package for RHEL also? I see %clean section and removal of buildroot in %install written in spec which is not needed in Fedora now


4) Remove the unnecessary comments.

Comment 2 Parag AN(पराग) 2012-03-30 07:16:47 UTC
any update?

Comment 3 Ding-Yi Chen 2012-04-02 05:45:12 UTC
(In reply to comment #1)
> 1) unable to find source tarball. See
> $ wget
> https://fedorahosted.org/releases/z/a/zanata-util/zanata-util-0.1.0.tar.gz
> --2012-03-27 10:49:13-- 
> https://fedorahosted.org/releases/z/a/zanata-util/zanata-util-0.1.0.tar.gz
> Resolving fedorahosted.org... 66.135.62.191
> Connecting to fedorahosted.org|66.135.62.191|:443... connected.
> HTTP request sent, awaiting response... 404 Not Found
> 2012-03-27 10:49:14 ERROR 404: Not Found.

Modified accordingly.

> 2) you don't need to write each perl package Requires: explicitly. They will
> get created automatically.

Modified accordingly.

> 3) Is this package for RHEL also? I see %clean section and removal of buildroot
> in %install written in spec which is not needed in Fedora now
 
Yes, I do intent to run it in EL5 and EL6.
 
> 4) Remove the unnecessary comments.
Modified accordingly.

I have been adding some extra functionality and man pages, thus it took a bit longer.

Comment 5 Parag AN(पराग) 2012-04-02 06:46:27 UTC
1)I did the scratch build of above updated srpm ->  http://koji.fedoraproject.org/koji/taskinfo?taskID=3955621
and I found some missing BR: in
http://koji.fedoraproject.org/koji/getfile?taskID=3955622&name=build.log

Add following in spec
BuildRequires:  perl(LWP::Protocol::https)
BuildRequires:  perl(List::MoreUtils)
BuildRequires:  perl(Locale::Country)

2) rpmlint on rpms gave
zanata-util.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
zanata-util.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
zanata-util.noarch: W: incoherent-version-in-changelog 0.2.0-1 ['0.2.1-1.fc18', '0.2.1-1']
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 7 Parag AN(पराग) 2012-04-02 09:57:46 UTC
Review:-
+ Koji scratch build for f18 ->koji.fedoraproject.org/koji/taskinfo?taskID=3956008

+ rpmlint on rpms gave 
zanata-util.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
zanata-util.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ source verified with upstream as
sha1sum zanata-util-0.2.2.tar.gz ../SOURCES/zanata-util-0.2.2.tar.gz 
d51d63e821596df0e50beb831fbb56b3b297fbe8  zanata-util-0.2.2.tar.gz
d51d63e821596df0e50beb831fbb56b3b297fbe8  ../SOURCES/zanata-util-0.2.2.tar.gz

+ Follows packaging guidelines


APPROVED.

Comment 8 Ding-Yi Chen 2012-04-03 00:25:02 UTC
New Package SCM Request
=======================
Package Name: zanata-util
Short Description: zanata-util is a collection of helper scripts that make using Zanata easier.
Owners: dchen
Branches: f17 f16 el5

Comment 9 Gwyn Ciesla 2012-04-03 13:55:48 UTC
Git done (by process-git-requests).

If you want EL-6, EL-6 might not be a bad idea either, but that's up to you.

Comment 10 Ding-Yi Chen 2012-04-03 23:28:24 UTC
Oops, I forgot to add el6. Please add it for me.
Thanks for kindly reminded me.

Comment 11 Fedora Update System 2012-04-04 01:50:15 UTC
zanata-util-0.2.3-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/zanata-util-0.2.3-1.el5

Comment 12 Fedora Update System 2012-04-04 03:27:06 UTC
zanata-util-0.2.3-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zanata-util-0.2.3-1.fc17

Comment 13 Ding-Yi Chen 2012-04-05 00:34:03 UTC
Package Change Request
======================
Package Name: zanata-util
New Branches: el6
Owners: dchen
InitialCC: 

As majority or our users are using EL6, I think el6 is essential.

Comment 14 Fedora Update System 2012-04-05 03:04:26 UTC
zanata-util-0.2.3-1.el5 has been pushed to the Fedora EPEL 5 testing repository.

Comment 15 Gwyn Ciesla 2012-04-05 12:11:32 UTC
Git done (by process-git-requests).

Comment 16 Fedora Update System 2012-04-10 00:45:35 UTC
zanata-util-0.2.3-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/zanata-util-0.2.3-1.el6

Comment 17 Fedora Update System 2012-04-20 03:08:39 UTC
zanata-util-0.2.3-1.fc17 has been pushed to the Fedora 17 stable repository.

Comment 18 Fedora Update System 2012-04-20 06:39:52 UTC
zanata-util-0.2.6-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/zanata-util-0.2.6-1.el5

Comment 19 Fedora Update System 2012-04-20 06:40:32 UTC
zanata-util-0.2.6-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/zanata-util-0.2.6-1.fc16

Comment 20 Fedora Update System 2012-04-20 06:40:49 UTC
zanata-util-0.2.6-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zanata-util-0.2.6-1.fc17

Comment 21 Fedora Update System 2012-04-20 06:41:07 UTC
zanata-util-0.2.6-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/zanata-util-0.2.6-1.el6

Comment 22 Fedora Update System 2012-04-27 00:27:18 UTC
zanata-util-0.2.7-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/zanata-util-0.2.7-1.fc16

Comment 23 Fedora Update System 2012-04-27 00:27:37 UTC
zanata-util-0.2.7-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/zanata-util-0.2.7-1.el6

Comment 24 Fedora Update System 2012-04-27 00:27:55 UTC
zanata-util-0.2.7-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zanata-util-0.2.7-1.fc17

Comment 25 Fedora Update System 2012-04-27 00:28:13 UTC
zanata-util-0.2.7-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/zanata-util-0.2.7-1.el5

Comment 26 Fedora Update System 2012-05-08 04:15:39 UTC
zanata-util-0.2.7-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2012-05-10 14:18:48 UTC
zanata-util-0.2.7-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2012-05-22 15:30:15 UTC
zanata-util-0.2.7-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 29 Fedora Update System 2012-05-22 15:31:52 UTC
zanata-util-0.2.7-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.