Bug 807240
Summary: | Review Request: microemulator - Java 2 Micro Edition (J2ME) CLDC/MIDP Emulator | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mizdebsk, package-review, puntogil |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | BuildFails | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-03-31 16:27:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
gil cattaneo
2012-03-27 10:51:12 UTC
*** Bug 807242 has been marked as a duplicate of this bug. *** I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. This fails to build for me. Here is a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5323207 Spec URL: http://gil.fedorapeople.org/microemulator.spec SRPM URL: http://gil.fedorapeople.org/microemulator-2.0.4-1.fc18.src.rpm (In reply to comment #2) > I am triaging old review tickets. I can't promise a review if you reply, > but by closing out the stale tickets we can devote extra attention to the > ones which aren't stale. thanks > > This fails to build for me. Here is a scratch build: > http://koji.fedoraproject.org/koji/taskinfo?taskID=5323207 added maven-local, should work now Package fails to bulid in rawdide. Also please update to latest packaging guidelines. (In reply to Mikolaj Izdebski from comment #5) > Package fails to bulid in rawdide. Also please update to latest packaging > guidelines. Spec URL: http://gil.fedorapeople.org/microemulator.spec SRPM URL: http://gil.fedorapeople.org/microemulator-2.0.4-1.fc20.src.rpm A few issues: Why are seds in lines 47-48 and 50-53 used? I don't think they are needed. You shouldn't be modifying licensing headers (lines 78-79). Extra LGPL license text should not be added. (In reply to Mikolaj Izdebski from comment #8) > A few issues: > Why are seds in lines 47-48 and 50-53 used? I don't think they are needed. > You shouldn't be modifying licensing headers (lines 78-79). > Extra LGPL license text should not be added. Spec URL: http://gil.fedorapeople.org/microemulator.spec SRPM URL: http://gil.fedorapeople.org/microemulator-2.0.4-2.fc20.src.rpm - removed unnecessary seds and license text file No more interested |