Bug 807607

Summary:	RESTAPI: Extend host_nics action with UpdateNetworks
Product:	[Retired] oVirt	Reporter:	Avi Tal <atal>
Component:	ovirt-engine-api	Assignee:	Moti Asayag <masayag>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, dyasny, iheim, lpeer, mpastern, rgolan, srevivo, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	Network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-16 06:57:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	329781

Description Avi Tal 2012-03-28 10:26:40 UTC

SetupNetwork feature is missing a very important update implementation.

VDSM is able to receive nics collection which describe which nics will be updated and handle only those nics.
This implementation is missing from backend. It automatically treat missing nics as nics we would like to remove.

A very buggy scenario would be, missing mgmt network.

The idea is to send (via REST API) a collection which contain only the interfaces (nics) we would like to update. 

This is actually an UPDATE collection procedure. it could be added as a different action:
http://engine ip:port/hosts/id/nics/updatenetworks

Comment 1 Michael Pasternak 2012-03-28 10:35:49 UTC

Roy, can you remind me what was the reason/s not implementing
setupnetworks via PUT?

Comment 2 Roy Golan 2012-05-16 12:18:47 UTC

setupnetworks is a creation API, it builds networks and removes others by sending the FULL desired topology to the backend. 

PUT shall allow you to send a small portion of the topology for update
i.e

PUT /api/hosts/{id}/nics

host_nics
 host_nic
  name: em1.300
  boot_protocol: dynamic

Comment 3 Itamar Heim 2012-12-16 06:57:29 UTC

Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.