Bug 807660

Summary: Duration field accepts hyphen (-) character
Product: [Other] RHQ Project Reporter: Sunil Kondkar <skondkar>
Component: Core UIAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: hrupp
Target Milestone: ---   
Target Release: RHQ 4.4.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-31 10:12:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Sunil Kondkar 2012-03-28 12:33:40 UTC 
Description of problem:

While creating an alert definition for availability duration, the 'Duration' field accepts hyphen (-) character with a number (Ex: -2). 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Navigate to Alerts->Definition tab of a resource
2.Click on New button
3.Enter the alert name
4. Click on the Conditions tab
5. Click on 'Add' button
6. Select 'Availability Duration' condition type
7. in 'Duration' field, enter hyphen character with a number (Ex: -2)
8. Click on OK button
9. Click on Save button
  
Actual results:

Duration field accepts hyphen (-) character

Expected results:

validation for invalid value with a red mark and user should not be able to click OK button.

Additional info:
Comment 1 Sunil Kondkar 2012-03-28 13:04:25 UTC 
Build#1203 (Version: 4.4.0-SNAPSHOT Build Number: 969ed45)
Comment 2 Jay Shaughnessy 2012-04-02 14:35:07 UTC 
master commit 9f328eaf22f68f9a6c549d5d4b30c154a15de78b

Replaced TextItem entry with our DurationItem widget. This gives us
consistency, reusability and validation.  Allow value in minutes or
hours, Duration should be displayed in minutes in the condition.
Comment 3 Sunil Kondkar 2012-04-17 11:58:44 UTC 
Verified on Version: 4.4.0-SNAPSHOT Build Number: 0fe1b14

Verified by choosing the duration values in mins and hours from duration dropdown.
The values are displayed in minutes in 'condition' tab. Invalid entries (Ex: with hyphen character display a red mark with a tool tip 'Must be atleast 1'.)
Comment 4 Heiko W. Rupp 2013-08-31 10:12:18 UTC 
Bulk close of old bugs in VERIFIED state.