Bug 808061

Summary:	[RFE] virt-who command line option improvements
Product:	Red Hat Enterprise Linux 5	Reporter:	Bryan Kearney <bkearney>
Component:	virt-who	Assignee:	Radek Novacek <rnovacek>
Status:	CLOSED ERRATA	QA Contact:	Entitlement Bugs <entitlement-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.9	CC:	bgollahe, cshao, dyasny, huiwang, khong, ndong, ovasik, pm-rhel, yqiao
Target Milestone:	rc	Keywords:	FutureFeature, Rebase
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-who-0.7-2.el5	Doc Type:	Rebase: Bug Fixes and Enhancements
Doc Text:		Story Points:	---
Clone Of:	808060	Environment:
Last Closed:	2013-01-08 07:35:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	848763, 848777, 848781
Bug Blocks:	771748

Description Bryan Kearney 2012-03-29 13:15:01 UTC

+++ This bug was initially created as a clone of Bug #808060 +++

Based on some usability discussions, we should enhance the cli command line options as follows.

1) virt-who 
Start in foreground, print errors to stderr (-d for debugging output)

2) virt-who -o
One-shot mode, exit after sending list of guests

3) virt-who -b
4) service virt-who start
Both the same: start on background (do double-fork), log to /var/log, no 
stdout/stderr

Comment 1 Radek Novacek 2012-07-09 12:54:09 UTC

It will be better to do a rebase, because this change affects quite big codebase. Other changes from upstream (couple of fixes that is already present in rhel-6)  needs to be dragged as well, so rebase makes sense.

Comment 2 Radek Novacek 2012-07-17 08:06:51 UTC

This feature has been implemented in virt-who-0.7-1.el5.

Comment 4 yqiao 2012-08-02 09:34:51 UTC

-b and -d options work well ,but some error happen to -o option as follows:


2012-08-01 23:27:40,303 [ERROR]  @virt-who.py:164 - Unable to create connection:
Traceback (most recent call last):
  File "/usr/share/virt-who/virt-who.py", line 161, in _send
    self.checkConnections()
  File "/usr/share/virt-who/virt-who.py", line 140, in checkConnections
    self.initVirt()
  File "/usr/share/virt-who/virt-who.py", line 95, in initVirt
    self.virt = Virt(self.logger)
  File "/usr/share/virt-who/virt.py", line 41, in __init__
    raise VirtError(str(e))
VirtError: adding cb to list
2012-08-01 23:27:40,310 [ERROR]  @virt-who.py:167 - Unable to recover

Comment 5 Radek Novacek 2012-08-07 08:36:23 UTC

Thanks for noticing, it has been fixed in virt-who-0.7-2.el5.

Comment 7 Hui Wang 2012-08-17 01:21:13 UTC

This issue will be as a tracker of the following bugs:
848763 848777 848781. After the all the bugs fixed, this bug will be closed.

Comment 8 Radek Novacek 2012-09-17 12:56:39 UTC

Removing dependence on bug 808060, because it's RHEL-6 bug.

Comment 9 Radek Novacek 2012-09-19 13:27:10 UTC

Dependent bugs are fixed, moving to ON_QA.

Comment 10 ndong 2012-09-20 06:32:04 UTC

Since the virt-who with -o function works well without errors in virt-who-0.7-6.el5, changed status from ON_QA to VERIFIED.

Comment 11 ndong 2012-09-20 08:24:33 UTC

The dependence bugs have been fixed. so moving the bug to Verified. Moreover, the virt-who with -o function works well without errors in virt-who-0.7-6.el5, changed status from ON_QA to VERIFIED.

Comment 13 errata-xmlrpc 2013-01-08 07:35:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0072.html