Bug 80822

Summary: broken source code
Product: [Retired] Red Hat Linux Reporter: d.binderman
Component: rshAssignee: Phil Knirsch <pknirsch>
Status: CLOSED RAWHIDE QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0CC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-01-17 16:37:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2002-12-31 18:06:21 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

Hello there,

I have just tried to compile package rsh-0.17-10 from Redhat 8.0

Here are some of the messages the compiler produces

cc: Info: rlogind.c, line 353: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)
cc: Info: rlogind.c, line 354: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)
cc: Info: rlogind.c, line 355: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)
cc: Info: rlogind.c, line 356: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)
cc: Info: rlogind.c, line 358: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)

Here is an untested patch to shut up the compiler.

./rlogind/rlogind.c.old ./rlogind/rlogind.c
*** ./rlogind/rlogind.c.old	Wed Dec 25 10:05:44 2002
--- ./rlogind/rlogind.c	Wed Dec 25 10:12:57 2002
***************
*** 336,342 ****
  		  const char *localuser, int authenticated,
  		  const char *rusername)
  {
!     char *termenv[2];
  
      setup_term(0, termtype);
  
--- 336,342 ----
  		  const char *localuser, int authenticated,
  		  const char *rusername)
  {
!     char *termenv[ 4];
  
      setup_term(0, termtype);
  


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compile with any C compiler that checks array indexes, for example Compaq.
2.
3.
    

Additional info:
Comment 1 Phil Knirsch 2003-01-17 16:37:01 UTC 
Fixed in rsh-0.17-13 (available via rawhide shortly).

Read ya, Phil