Bug 808979

Description of problem:

Each time virsh vcpuinfo is run (or virDomainGetVcpus is called) a small amount of memory is leaked.

Version-Release number of selected component (if applicable):

Every version of libvirt between 0.7.5 and 0.9.10-9


How reproducible: 100%

Steps to Reproduce:

1) stop libvirtd - "/etc/init.d/libvirtd stop"

2) run libvirtd under valgrind - "valgrind --leak-check=full libvirtd" 

3) run "virsh vcpuinfo $guest" many times ($guest is the name of some active guest)

4) ctl-C out of the valgrind commend in step 2.
  
Actual results:

One "cpuset" (128 bytes in the case of my machine, which has 6 cores) will be leaked for each time virsh vcpuinfo is called - you will see a record similar to the following in the valgrind output:

==19980== 6,400 bytes in 50 blocks are definitely lost in loss record 911 of 924
==19980==    at 0x4A074CD: malloc (vg_replace_malloc.c:236)
==19980==    by 0x3CAAC65860: virProcessInfoGetAffinity (processinfo.c:120)
==19980==    by 0x460DC0: qemudDomainGetVcpus (qemu_driver.c:3781)
==19980==    by 0x3CAACF9710: virDomainGetVcpus (libvirt.c:8915)
==19980==    by 0x43B519: remoteDispatchDomainGetVcpusHelper (remote.c:1498)
==19980==    by 0x3CAAD48354: virNetServerProgramDispatch (virnetserverprogram.c:416)
==19980==    by 0x3CAAD42E10: virNetServerHandleJob (virnetserver.c:164)
==19980==    by 0x3CAAC6B7ED: virThreadPoolWorker (threadpool.c:144)
==19980==    by 0x3CAAC6AE95: virThreadHelper (threads-pthread.c:161)
==19980==    by 0x32E0207D8F: start_thread (pthread_create.c:309)
==19980==    by 0x32DFEF0F5C: clone (clone.S:115)

(I had run "virsh vcpuinfo $guest" 50 times)

Expected results:

There should be no such record in the valgrind output.

Solution:

The problem is caused by virProcessInfoGetAffinity calling CPU_ALLOC() but not calling CPU_FREE(). I'm posting a fix upstream momentarily, and will enter the commit ID here once it's been pushed.