Bug 809257

Summary: Identity cert regeneration causes all non-protected repos to become protected
Product: Red Hat Update Infrastructure for Cloud Providers Reporter: James Slagle <jslagle>
Component: RHUAAssignee: James Slagle <jslagle>
Status: CLOSED ERRATA QA Contact: wes hayutin <whayutin>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.0.3CC: kbidarka, lbrindle, mkovacik, sghai, tsanders
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
C: When a new identity certificate was generated, it was being uploaded as a new consumer bundle to all repositories, including protected repositories. C: Regenerating an identity certificate caused all non-protected repositories to become protected repositories. F: New identity certificates are now only uploaded to protected repositories. R: Non-protected repositories remain non-protected after a new identity certificate has been generated and uploaded. Final: * When a new identity certificate was generated, it was being uploaded as a new consumer bundle to all repositories, including protected repositories. Regenerating an identity certificate caused all non-protected repositories to become protected repositories. New identity certificates are now only uploaded to protected repositories and non-protected repositories remain non-protected. (BZ#809257)
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-01 18:37:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Verifying log none

Description James Slagle 2012-04-02 21:24:57 UTC
When a new identity cert is generated, we blindly upload it as a new consumer bundle to all repos, including custom repos, regardless of whether or not the custom repo is protected.

This causes the following traceback from rhui-manager:
Unexpected error caught at the shell level
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/rhui/tools/shell.py", line 87, in safe_listen
    self.listen(clear=first_run)
  File "/usr/lib/python2.6/site-packages/rhui/tools/shell.py", line 113, in listen
    Shell.listen(self)
  File "/usr/lib/python2.6/site-packages/rhui/common/shell.py", line 191, in listen
    item.func(*args, **item.kwargs)
  File "/usr/lib/python2.6/site-packages/rhui/tools/screens/client.py", line 71, in generate
    menu_item = ent.download_url + '\n'
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

The traceback is because entitlment-path is None in the repo notes for unprotected custom repos.

Comment 1 mkovacik 2012-04-03 08:36:53 UTC
The error in Description may manifest as Bug 808047, too

Comment 2 James Slagle 2012-04-09 15:18:34 UTC
made change to only upload a new identity cert to protected repos, committed to cloude master: eaa7fba7edd77caa9ba4e77326343a5622223286

Comment 3 James Slagle 2012-04-09 15:19:12 UTC
*** Bug 808047 has been marked as a duplicate of this bug. ***

Comment 4 mkovacik 2012-04-17 10:53:17 UTC
Verified trough  Bug 808047 steps in RHEL-6.2-RHUI-2.0.3-20120416.0-Server-x86_64-DVD1.iso. The traceback can't be seen in the logs any more, either.

Comment 5 mkovacik 2012-04-17 10:54:29 UTC
Created attachment 577992 [details]
Verifying log

Comment 6 Lana Brindley 2012-04-20 01:51:47 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: When a new identity certificate was generated, it was being uploaded as a new consumer bundle to all repositories, including protected repositories.
C: Regenerating an identity certificate caused all non-protected repositories to become protected repositories.
F: New identity certificates are now only uploaded to protected repositories.
R: Non-protected repositories remain non-protected after a new identity certificate has been generated and uploaded.

Comment 7 Lana Brindley 2012-04-20 04:31:13 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,4 +1,7 @@
 C: When a new identity certificate was generated, it was being uploaded as a new consumer bundle to all repositories, including protected repositories.
 C: Regenerating an identity certificate caused all non-protected repositories to become protected repositories.
 F: New identity certificates are now only uploaded to protected repositories.
-R: Non-protected repositories remain non-protected after a new identity certificate has been generated and uploaded.+R: Non-protected repositories remain non-protected after a new identity certificate has been generated and uploaded.
+
+Final:
+* When a new identity certificate was generated, it was being uploaded as a new consumer bundle to all repositories, including protected repositories. Regenerating an identity certificate caused all non-protected repositories to become protected repositories. New identity certificates are now only uploaded to protected repositories and non-protected repositories remain non-protected. (BZ#809257)

Comment 8 errata-xmlrpc 2012-05-01 18:37:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0539.html