Bug 809366
| Summary: | REST API: SetupNetworks response body should contain the new host_nics collection | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Avi Tal <atal> |
| Component: | ovirt-engine-restapi | Assignee: | Ori Liel <oliel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yaniv Kaul <ykaul> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.1.0 | CC: | acathrow, bazulay, dyasny, ecohen, iheim, jkt, lpeer, mgoldboi, mkolesni, mpastern, Rhev-m-bugs, sgrinber, srevivo, ykaul |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | infra network | ||
| Fixed In Version: | si16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-04 20:02:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Avi Tal
2012-04-03 08:17:14 UTC
This is very important for the REST API tests process. part of the test is to validate the response code and body after sending action/request which in this case can't be done! The return value for REST action is the action contents + status of the request, is this what you want to get back? yes response body should contain action status posted patch: http://gerrit.ovirt.org/#/c/6968/1 merged, commit 39728d8b9ab74c0604b55d29183bf75a181e82e6 Verify on SI16 - PASS
Response for setupnetworks action:
<action>
<host_nics>
<actions>
<link href="/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/setupnetworks" rel="setupnetworks"/>
</actions>
<host_nic href="/api/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/52333f8c-3f97-486a-bfa2-d88e379e2ad0" id="52333f8c-3f97-486a-bfa2-d88e379e2ad0">
<actions>
<link href="/api/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/52333f8c-3f97-486a-bfa2-d88e379e2ad0/attach" rel="attach"/>
<link href="/api/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/52333f8c-3f97-486a-bfa2-d88e379e2ad0/detach" rel="detach"/>
</actions>
<name>eth0</name>
<link href="/api/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763/nics/52333f8c-3f97-486a-bfa2-d88e379e2ad0/statistics" rel="statistics"/>
<host href="/api/hosts/1d1683d0-f2a7-11e1-b6f8-001a4a169763" id="1d1683d0-f2a7-11e1-b6f8-001a4a169763"/>
<network href="/api/networks/31969310-1452-4d8b-b71f-ffb086fe657a" id="31969310-1452-4d8b-b71f-ffb086fe657a"/>
<mac address="00:15:17:A7:6A:4C"/>
<ip address="10.35.128.10" netmask="255.255.255.0" gateway="10.35.128.254"/>
<boot_protocol>dhcp</boot_protocol>
<speed>1000000000</speed>
<status>
<state>up</state>
</status>
<mtu>1500</mtu>
<bridged>true</bridged>
<custom_configuration>false</custom_configuration>
</host_nic>
</host_nics>
<status>
<state>complete</state>
</status>
</action>
(In reply to comment #2) > The return value for REST action is the action contents + status of the > request, is this what you want to get back? this is incorrect, you should query for host nics (after the action complited) and return them in response, otherwise it's a fake, QE verify action success based on your response. (In reply to comment #8) > (In reply to comment #2) > > The return value for REST action is the action contents + status of the > > request, is this what you want to get back? > > this is incorrect, you should query for host nics (after the action > complited) and return them in response, otherwise it's a fake, QE verify > action success based on your response. will be addressed in https://bugzilla.redhat.com/show_bug.cgi?id=853739 |