Bug 810033

Review checklist, last updated 2012-02-07
Based on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
Key: [X] passed, [F] failed, [-] irrelevant

[F] MUST: rpmlint must be run on the source rpm and all binary rpms the build
    produces. The output should be posted in the review.

python-virtualenvwrapper.src: W: spelling-error Summary(en_US) virtualenv -> virtual
python-virtualenvwrapper.src: W: spelling-error %description -l en_US virtualenv -> virtual
python-virtualenvwrapper.src: W: spelling-error %description -l en_US http -> HTTP
python-virtualenvwrapper.src: W: spelling-error %description -l en_US pypi -> typify
python-virtualenvwrapper.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
python-virtualenvwrapper.noarch: W: spelling-error Summary(en_US) virtualenv -> virtual
python-virtualenvwrapper.noarch: W: spelling-error %description -l en_US virtualenv -> virtual
python-virtualenvwrapper.noarch: W: spelling-error %description -l en_US http -> HTTP
python-virtualenvwrapper.noarch: W: spelling-error %description -l en_US pypi -> typify
python-virtualenvwrapper.noarch: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce
python-virtualenvwrapper.noarch: E: script-without-shebang /usr/bin/virtualenvwrapper.sh
python-virtualenvwrapper.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/virtualenvwrapper/project.py 0644L /usr/bin/env
python-virtualenvwrapper.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/virtualenvwrapper/user_scripts.py 0644L /usr/bin/env
python-virtualenvwrapper.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/virtualenvwrapper/hook_loader.py 0644L /usr/bin/env
python-virtualenvwrapper.noarch: W: no-manual-page-for-binary virtualenvwrapper.sh
2 packages and 0 specfiles checked; 4 errors, 11 warnings.

The errors (script-without-shebang and non-executable-script) must be fixed.
(non-executable-script is being thrown because those files have shebangs and
shouldn't).

[X] MUST: The package must be named according to the Package Naming Guidelines.
[X] MUST: The spec file name must match the base package %{name}, in the format
    %{name}.spec unless your package has an exemption.
[ ] MUST: The package must meet the Packaging Guidelines.
[X] MUST: The package must be licensed with a Fedora approved license and meet
    the Licensing Guidelines.
[X] MUST: The License field in the package spec file must match the actual
    license. 

The README.txt included has a license that is obviously MIT but the PyPi page
labels this module as BSD licensed. Please contact upstream and have them fix
something.

[-] MUST: If (and only if) the source package includes the text of the
    license(s) in its own file, then that file, containing the text of the
    license(s) for the package must be included in %doc.
[X] MUST: The spec file must be written in American English. 
[X] MUST: The spec file for the package MUST be legible. 
[X] MUST: The sources used to build the package must match the upstream source,
    as provided in the spec URL. Reviewers should use md5sum for this task. If
    no upstream URL can be specified for this package, please see the Source
    URL Guidelines for how to deal with this.

8a37fc179d3e0239c42cda433a21009a  virtualenvwrapper-3.1.tar.gz
8a37fc179d3e0239c42cda433a21009a  virtualenvwrapper-3.1.tar.gz.1

[X] MUST: The package MUST successfully compile and build into binary rpms on
    at least one primary architecture. 
[-] MUST: If the package does not successfully compile, build or work on an
    architecture, then those architectures should be listed in the spec in
    ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed
    in bugzilla, describing the reason that the package does not
    compile/build/work on that architecture. The bug number MUST be placed in a
    comment, next to the corresponding ExcludeArch line. 
[X] MUST: All build dependencies must be listed in BuildRequires, except for
    any that are listed in the exceptions section of the Packaging Guidelines;
    inclusion of those as BuildRequires is optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by using the
    %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-] MUST: Every binary RPM package (or subpackage) which stores shared library
    files (not just symlinks) in any of the dynamic linker's default paths,
    must call ldconfig in %post and %postun. 
[X] MUST: Packages must NOT bundle copies of system libraries.
[-] MUST: If the package is designed to be relocatable, the packager must state
    this fact in the request for review, along with the rationalization for
    relocation of that specific package. Without this, use of Prefix: /usr is
    considered a blocker. 
[X] MUST: A package must own all directories that it creates. If it does not
    create a directory that it uses, then it should require a package which
    does create that directory. 
[X] MUST: A Fedora package must not list a file more than once in the spec
    file's %files listings. (Notable exception: license texts in specific
    situations)
[X] MUST: Permissions on files must be set properly. Executables should be set
    with executable permissions, for example. 
[X] MUST: Each package must consistently use macros. 
[X] MUST: The package must contain code, or permissable content. 
[-] MUST: Large documentation files must go in a -doc subpackage. (The
    definition of large is left up to the packager's best judgement, but is not
    restricted to size. Large can refer to either size or quantity). 
[X] MUST: If a package includes something as %doc, it must not affect the
    runtime of the application. To summarize: If it is in %doc, the program
    must run properly if it is not present. 
[-] MUST: Static libraries must be in a -static package. 
[-] MUST: Development files must be in a -devel package. 
[-] MUST: In the vast majority of cases, devel packages must require the base
    package using a fully versioned dependency:
       Requires: %{name}%{?_isa} = %{version}-%{release} 
[-] MUST: Packages must NOT contain any .la libtool archives, these must be
    removed in the spec if they are built.
[-] MUST: Packages containing GUI applications must include a %{name}.desktop
    file, and that file must be properly installed with desktop-file-install in
    the %install section. If you feel that your packaged GUI application does
    not need a .desktop file, you must put a comment in the spec file with your
    explanation. 
[X] MUST: Packages must not own files or directories already owned by other
    packages. The rule of thumb here is that the first package to be installed
    should own the files or directories that other packages may rely upon. This
    means, for example, that no package in Fedora should ever share ownership
    with any of the files or directories owned by the filesystem or man
    package. If you feel that you have a good reason to own a file or directory
    that another package owns, then please present that at package review time. 
[X] MUST: All filenames in rpm packages must be valid UTF-8. 

Fixes required: rpmlint

I filed an issue upstream about the license ambiguity but will have to take a crack at rpmlint later.

 - https://bitbucket.org/dhellmann/virtualenvwrapper/issue/134/license-ambiguity

That patch got merged in upstream and a new version was released.

Here is an updated RPM for the latest version that also contains a patch for the rpmlint issues.

SPEC:  http://threebean.org/rpm/python-virtualenvwrapper.spec
SRPM:  http://threebean.org/rpm/python-virtualenvwrapper-3.2-1.fc17.src.rpm

/usr/bin/virtualenvwrapper.sh still doesn't have a shebang and it requires one:

python-virtualenvwrapper.noarch: E: script-without-shebang /usr/bin/virtualenvwrapper.sh

Whoops -- I went the wrong way.  I made the script non-executable instead of adding a shebang.

This has been reversed.  It is executable again and has a shebang now.  Bumped the release in the spec.

SPEC:  http://threebean.org/rpm/python-virtualenvwrapper.spec
SRPM:  http://threebean.org/rpm/python-virtualenvwrapper-3.2-2.fc17.src.rpm

Alright, looks good. APPROVED

New Package SCM Request
=======================
Package Name: python-virtualenvwrapper
Short Description: Enhancements to virtualenv
Owners: ralph
Branches: f17 el6
InitialCC:

Git done (by process-git-requests).

python-virtualenvwrapper-3.2-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-virtualenvwrapper-3.2-2.fc17

python-virtualenvwrapper-3.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-virtualenvwrapper-3.2-2.el6

python-virtualenvwrapper-3.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

python-virtualenvwrapper-3.2-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-virtualenvwrapper-3.2-3.fc17

python-virtualenvwrapper-3.2-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-virtualenvwrapper-3.2-3.el6

python-virtualenvwrapper-3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

python-virtualenvwrapper-3.2-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: python-virtualenvwrapper
New Branches: f16
Owners: ralph
InitialCC:

Git done (by process-git-requests).

Nice post. I was checking constantly this blog and I’m impressed! Thank You.
https://shryashrama.com
https://shryashrama.com/shrya/
https://www.bonitacollections.com

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days