Bug 810707

Summary: Circular build dependency in perl-MooseX-Getopt-0.39-1.fc18
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: perl-MooseX-GetoptAssignee: Iain Arnell <iarnell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: iarnell, mmaslano, perl-devel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-MooseX-Getopt-0.39-2.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-09 14:34:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Paul Howarth 2012-04-08 13:34:13 UTC
perl-MooseX-Getopt buildrequires perl(MooseX::SimpleConfig)
  [optional test requirement]

perl-MooseX-SimpleConfig buildrequires perl(MooseX::ConfigFromFile)
  [explicit requirement]

perl-MooseX-ConfigFromFile buildrequires perl(MooseX::Types::Path::Class)
  [hard module requirement]

perl-MooseX-Types-Path-Class buildrequires perl(MooseX::Getopt)
  [optional requirement]

Given that the perl(MooseX::SimpleConfig) requirement of perl-MooseX-Getopt is only an optional test requirement, that would seem to be the place place to break this cycle:

diff --git a/perl-MooseX-Getopt.spec b/perl-MooseX-Getopt.spec
index f65b76b..6ad5841 100644
--- a/perl-MooseX-Getopt.spec
+++ b/perl-MooseX-Getopt.spec
@@ -14,7 +14,10 @@ BuildRequires:  perl(Getopt::Long) >= 2.37
 BuildRequires:  perl(Getopt::Long::Descriptive) >= 0.081
 BuildRequires:  perl(Moose) >= 0.56
 BuildRequires:  perl(MooseX::Role::Parameterized)
+# MooseX::SimpleConfig -> MooseX::ConfigFromFile -> MooseX::Types::Path::Class -> MooseX::Getopt
+%if 0%{!?perl_bootstrap:1}
 BuildRequires:  perl(MooseX::SimpleConfig) >= 0.07
+%endif
 BuildRequires:  perl(Test::Deep)
 BuildRequires:  perl(Test::Fatal) >= 0.003
 BuildRequires:  perl(Test::Moose)

Comment 1 Iain Arnell 2012-04-09 14:34:44 UTC
Thanks. Patch committed and built for rawhide.