| Summary: | fix broken %if 0%{?fedora} conditionals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Mach <dmach> |
| Component: | NetworkManager | Assignee: | Dan Williams <dcbw> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 17 | CC: | dcbw, jklimes |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-10 07:54:35 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Fixed both in rawhide and F17. Thanks. |
If the "fedora" macro is not defined, then 0%{?fedora} < 17 is always true. This leads to broken builds when building the package in different environments. A good practice is to test if %fedora is set and only then proceed with the version comparison. Can you apply following change to spec? (there are 2 occurences of this problem): -%if 0%{?fedora} < 17 +%if 0%{?fedora} && 0%{?fedora} < 17