Bug 81086
| Summary: | wrong code in windows.jl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Public Beta | Reporter: | Gérard Milmeister <gemi> | ||||
| Component: | sawfish | Assignee: | Havoc Pennington <hp> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | phoebe | CC: | redhat-bugzilla, wtogami | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2003-01-28 23:27:33 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 79579 | ||||||
| Attachments: |
|
||||||
Ran into this with mplayer-0.90rc2. Upstream as http://bugzilla.gnome.org/show_bug.cgi?id=103319 It isn't a feature request as your reported in the gnome bug. Without the fix when using mplayer-0.90rc2 and pressing f for fullscreen it doesn't fullscreen right, gives an error in .xsession-errors, and beeps(sign of error). If you so don't want to maintain sawfish in RedHat why don't you just drop the package and then everyone will move on. Here is a message to me from John Harper on the sawfish mailing list back in November saying he fixed this in CVS. Should you could try using CVS instead of the offical 1.2 release, like you have done in the past. http://lists.eazel.com/pipermail/sawfish/2002-November/004243.html We are packaging Sawfish (maintaining the spec file, tracking new versions, passing bugs along to upstream), but not much beyond that. Some people like to have it in RPM format on the CD. I don't see the harm in that. I'm not sure what other changes would come with a CVS snap, so I'd prefer to stick to something that's known to mostly work, as I don't have any firsthand knowledge. Created attachment 89330 [details]
Patch against sawfish-1.2 to fix windows.jl
I am one of the people that does like it included on the cd. But I would rather have it not on the CD so that someone else actually does maintain it at something like FreshRPMS or FalseHope instead of letting it rott in the distribution. I have attched the above patch in hopes that you will include it, and if not for others who are attached to this bug report or might find it in the future. OK, will put in the patch. In 1.2-4 |
From Bugzilla Helper: User-Agent: Mozilla/5.0 Galeon/1.2.7 (X11; Linux i686; U;) Gecko/20021128 Description of problem: The code for adjust-position-for-gravity/y in windows.jl must be: (let* ((tl-off (cdr (window-frame-offset w))) instead of: (let* ((tl-off (window-frame-offset w)) Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: N/A Additional info: