Bug 810865

Summary: Circular build dependency in perl-Dancer-1.3093-1.fc18
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: perl-DancerAssignee: Marcela Mašláňová <mmaslano>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jose.p.oliveira.oss, mmaslano, perl-devel
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-Dancer-1.3095-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-26 09:22:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Paul Howarth 2012-04-09 12:53:13 UTC
perl-Dancer has an optional test dependency of perl(Dancer::Session::Cookie) >= 0.14, which pulls in perl-Dancer-Session-Cookie. However, that requires perl-Dancer itself and thus introduces a circular dependency. Suggested fix - wrap that buildreq with a %perl_bootstrap conditional:

diff --git a/perl-Dancer.spec b/perl-Dancer.spec
index c7ee3be..04084a9 100644
--- a/perl-Dancer.spec
+++ b/perl-Dancer.spec
@@ -62,7 +62,10 @@ BuildRequires:  perl(Test::Builder)
 BuildRequires:  perl(URI::Escape)
 # Optional tests:
 BuildRequires:  perl(HTTP::Parser::XS)
+# Dancer::Session::Cookie needs Dancer itself
+%if 0%{!?perl_bootstrap:1}
 BuildRequires:  perl(Dancer::Session::Cookie) >= 0.14
+%endif
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 Requires:       perl(HTTP::Body) >= 1.07
 Requires:       perl(HTTP::Server::Simple::PSGI) >= 0.11

I tested this on F-17 as mod_perl is pulled in as a buildreq and it's currently uninstallable in Rawhide.

Comment 1 Marcela Mašláňová 2012-04-10 09:21:04 UTC
Thanks, it's test BR only.

Comment 2 Marcela Mašláňová 2012-04-10 10:19:27 UTC
Waiting for fix of httpd-mmn.

Comment 3 Marcela Mašláňová 2012-04-26 09:22:08 UTC
I guess this is fixed now.

Comment 4 Paul Howarth 2012-04-26 09:56:49 UTC
Yes, perl-Dancer-1.3095-1.fc18 has the fix, thanks. I just built it since the original attempt failed due to mod_perl.