| Summary: | Review Request: perl-bareword-filehandles - Disables bareword filehandles | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://search.cpan.org/dist/bareword-filehandles/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-bareword-filehandles-0.003-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-19 06:57:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Iain Arnell
2012-04-09 17:09:07 UTC
Source file is original. Ok.
URL and Source0 are usable Ok.
Summary verified from lib/bareword/filehandles.pm. Ok.
License verified from lib/bareword/filehandles.pm and LICENSE. Ok.
Description verified from lib/bareword/filehandles.pm. Ok.
Package uses XS code, architecture specific BuilArch is Ok.
All releases provide perl(Test::Pod::Coverage) >= 1.08, nonqualified dependency is Ok.
All releases provide perl(Test::Pod) >= 1.41, nonqualified dependency is Ok.
TODO: If you have patched Lexical::SealRequireHints dependency out, then you could remove `perl >= 0:5.008001' build-require.
All tests pass. Ok.
$ rpmlint perl-bareword-filehandles.spec ../SRPMS/perl-bareword-filehandles-0.003-1.fc18.src.rpm ../RPMS/x86_64/perl-bareword-filehandles-*
perl-bareword-filehandles.src: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically
perl-bareword-filehandles.src: W: spelling-error %description -l en_US builtin -> built in, built-in, built
perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically
perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US builtin -> built in, built-in, built
perl-bareword-filehandles.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE
3 packages and 1 specfiles checked; 1 errors, 4 warnings.
TODO: Correct `builtin' spelling.
TODO: Report to upstream out-dated FSF address
$ rpm -q -lv -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword
drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles
-rwxr-xr-x 1 root root 10216 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles/filehandles.so
drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword
-rw-r--r-- 1 root root 1815 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword/filehandles.pm
drwxr-xr-x 2 root root 0 May 4 15:22 /usr/share/doc/perl-bareword-filehandles-0.003
-rw-r--r-- 1 root root 356 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/Changes
-rw-r--r-- 1 root root 18291 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE
-rw-r--r-- 1 root root 316 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/README
-rw-r--r-- 1 root root 2245 May 4 15:22 /usr/share/man/man3/bareword::filehandles.3pm.gz
File layout is Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 perl(B::Hooks::OP::Check)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c
1 perl(bareword::filehandles) = 0.003
1 perl-bareword-filehandles = 0.003-1.fc18
1 perl-bareword-filehandles(x86-64) = 0.003-1.fc18
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm
Binary dependencies resolvable. Ok.
Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052725). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing all `TODO' items before building this package.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-bareword-filehandles Short Description: Disables bareword filehandles Owners: iarnell Branches: f16 f17 InitialCC: perl-sig Git done (by process-git-requests). Thanks, Petr. Imported with the TODO fixes. Upstream uses dist-zilla, so should automatically get the correct FSF address with the next release. perl-bareword-filehandles-0.003-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-bareword-filehandles-0.003-2.fc17 perl-bareword-filehandles-0.003-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-bareword-filehandles-0.003-2.fc16 perl-bareword-filehandles-0.003-2.fc17 has been pushed to the Fedora 17 testing repository. perl-bareword-filehandles-0.003-2.fc16 has been pushed to the Fedora 16 stable repository. perl-bareword-filehandles-0.003-2.fc17 has been pushed to the Fedora 17 stable repository. |