Bug 811113
Summary: | Quiet down the startup of sssd | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Stef Walter <stefw> | ||||||
Component: | sssd | Assignee: | Jakub Hrozek <jhrozek> | ||||||
Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 26 | CC: | fidencio, jhrozek, lslebodn, sbose, sgallagh, ssorce, stefw | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-04-11 15:49:15 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Stef Walter
2012-04-10 07:42:05 UTC
Upstream ticket: https://fedorahosted.org/sssd/ticket/1294 (In reply to comment #0) > When SSSD is started with a debug level that should show failures, lots of > messages that have nothing to do with failure show up. This obscures the actual > problems. > Many of the DEBUG statements, especially in code that hasn't been touched for some time, still use the old numeric levels. Changing them to the new debug levels (SSSDBG_*) would certainly be welcome. > I'll submit some patches to reassign some of the messages to the correct > locations. > Thank you. See https://fedorahosted.org/pipermail/sssd-devel/2011-June/006420.html for a short explanation of the different log levels. Created attachment 577074 [details]
Move some debug lines to new debug log levels
* These are common lines of debug output when starting
up sssd
Comments on some of the changes:
This isn't an error, legitimate configuration:
+ DEBUG(SSSDBG_TRACE_FUNC, ("No enumeration for [%s]!\n", domain->name));
Not errors, using service discovery is 'best' practice:
+ DEBUG(SSSDBG_TRACE_FUNC, ("No KDC explicitly configured, using defaults.\n"));
+ DEBUG(SSSDBG_TRACE_FUNC, ("No kpasswd server explicitly configured, "
+ "using the KDC or defaults.\n"));
+ DEBUG(SSSDBG_TRACE_FUNC, ("Missing krb5_server option, using service discovery!\n
+ DEBUG(SSSDBG_TRACE_FUNC, ("Missing krb5_server option, using service discovery!\n
+ DEBUG(SSSDBG_TRACE_FUNC, ("Missing ldap_uri, will use service discovery\n"));
Describe where the pid file failed to be created:
+ DEBUG(0, ("Error creating pidfile: %s/%s! (%d [%s])\n",
+ PID_PATH, name, ret, strerror(ret)));
In cases where this is an error, caller prints out a relevant message:
- DEBUG(SSSDBG_MINOR_FAILURE,
+ DEBUG(SSSDBG_TRACE_FUNC,
("No principal matching %s@%s found in keytab.\n",
pattern_primary, pattern_realm));
This is expected to fail in many cases. In cases where this is an error
caller prints out a relevant message:
- DEBUG(1, ("lstat for [%s] failed: [%d][%s].\n", filename, errno,
- strerror(errno)));
+ DEBUG(SSSDBG_TRACE_FUNC, ("lstat for [%s] failed: [%d][%s].\n", filename, errno,
+ strerror(errno)))
(In reply to comment #3) > Created attachment 577074 [details] > Move some debug lines to new debug log levels > > * These are common lines of debug output when starting > up sssd > > Comments on some of the changes: > > This isn't an error, legitimate configuration: > + DEBUG(SSSDBG_TRACE_FUNC, ("No enumeration for [%s]!\n", > domain->name)); > > Not errors, using service discovery is 'best' practice: > + DEBUG(SSSDBG_TRACE_FUNC, ("No KDC explicitly configured, using > defaults.\n")); > + DEBUG(SSSDBG_TRACE_FUNC, ("No kpasswd server explicitly configured, " > + "using the KDC or defaults.\n")); > + DEBUG(SSSDBG_TRACE_FUNC, ("Missing krb5_server option, using service > discovery!\n > + DEBUG(SSSDBG_TRACE_FUNC, ("Missing krb5_server option, using service > discovery!\n > + DEBUG(SSSDBG_TRACE_FUNC, ("Missing ldap_uri, will use service > discovery\n")); > All of the above should be SSSDBG_CONF_SETTINGS, not SSSDBG_TRACE_FUNC > Describe where the pid file failed to be created: > + DEBUG(0, ("Error creating pidfile: %s/%s! (%d [%s])\n", > + PID_PATH, name, ret, strerror(ret))); > Please do not add numeric debug levels. In this case it should be SSSDBG_FATAL_FAILURE because this error prevents the entire system from working. > In cases where this is an error, caller prints out a relevant message: > - DEBUG(SSSDBG_MINOR_FAILURE, > + DEBUG(SSSDBG_TRACE_FUNC, > ("No principal matching %s@%s found in keytab.\n", > pattern_primary, pattern_realm)); > Looks right. > This is expected to fail in many cases. In cases where this is an error > caller prints out a relevant message: > - DEBUG(1, ("lstat for [%s] failed: [%d][%s].\n", filename, errno, > - strerror(errno))); > + DEBUG(SSSDBG_TRACE_FUNC, ("lstat for [%s] failed: [%d][%s].\n", > filename, errno, > + > strerror(errno))) Looks right. I haven't reviewed the rest of the patch yet. Created attachment 577155 [details]
Updated for Stephen's initial review
Move some debug lines to new debug log levels
* These are common lines of debug output when starting
up sssd
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Still an issue, planned for next upstream version. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. As this is an RFE that we've been already tracking in our pagure I'm closing this bug as "UPSTREAM". For more details, please, feel free to follow: https://pagure.io/SSSD/sssd/issue/1294 If, for some reason, there's the need to re-open this bug, feel free to do so. |