Bug 811759
| Summary: | Review Request: python-tw2-excanvas - Excanvas for ToscaWidgets2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-22 15:39:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 720818 | ||
| Bug Blocks: | 812059, 818293 | ||
|
Description
Ralph Bean
2012-04-11 22:23:32 UTC
Updated to make some changes I learned from my last package review. Spec URL: http://threebean.org/rpm/python-tw2-excanvas.spec SRPM URL: http://threebean.org/rpm/python-tw2-excanvas-2.0.0-2.fc17.src.rpm koji scratch builds fail only because python-tw2-core is still in updates-testing. If you add updates-testing to your mock config, fedora-review should be able to run just fine. Upstream version bump to include proper LICENSE file. Spec URL: http://threebean.org/rpm/python-tw2-excanvas.spec SRPM URL: http://threebean.org/rpm/python-tw2-excanvas-2.0.1-1.fc17.src.rpm == REVIEW == Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - %check okay APPROVED. New Package SCM Request ======================= Package Name: python-tw2-excanvas Short Description: Excanvas for ToscaWidgets2 Owners: ralph Branches: f17 el6 InitialCC: Git done (by process-git-requests). python-tw2-excanvas-2.0.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-tw2-excanvas-2.0.2-1.fc17 python-tw2-excanvas-2.0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tw2-excanvas-2.0.2-1.el6 python-tw2-excanvas-2.0.2-1.fc17 has been pushed to the Fedora 17 testing repository. python-tw2-excanvas-2.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. python-tw2-excanvas-2.0.2-1.fc17 has been pushed to the Fedora 17 stable repository. Package Change Request ====================== Package Name: python-tw2-excanvas New Branches: epel7 Owners: ralph InitialCC: Git done (by process-git-requests). |