Bug 811769

Spec URL: http://threebean.org/rpm/python-tw2-dynforms.spec
SRPM URL: http://threebean.org/rpm/python-tw2-dynforms-2.0.1-1.fc17.src.rpm

New upstream release includes LICENSE file.

There are only 2 small issues: a missing "-1" in the most recent changelog entry, and a directory ownership issue (see below).

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint python-tw2-dynforms-2.0.1-1.fc18.noarch.rpm

python-tw2-dynforms.noarch: W: incoherent-version-in-changelog 2.0.1 ['2.0.1-1.fc18', '2.0.1-1']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint python-tw2-dynforms-2.0.1-1.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/jamesjer/811769/tw2.dynforms-2.0.1.tar.gz :
  MD5SUM this package     : 0d1644e87ed7d165bf4196c3d3d2ec04
  MD5SUM upstream package : 0d1644e87ed7d165bf4196c3d3d2ec04

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Rpmlint output is silent.

rpmlint python-tw2-dynforms-2.0.1-1.fc18.noarch.rpm

python-tw2-dynforms.noarch: W: incoherent-version-in-changelog 2.0.1 ['2.0.1-1.fc18', '2.0.1-1']
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint python-tw2-dynforms-2.0.1-1.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[!]: MUST Package does not own files or directories owned by other packages.

This package owns %{python2_sitelib}/tw2, which is already owned by python-tw2-core and python-tw2-forms.  Since python-tw2-core is required for any other python-tw2-* package to be installed, it should be the only package owning that directory.  The python-tw2-forms package and this package should both be altered to not own that directory.

Generated by fedora-review 0.1.3
External plugins:

New release:  fixes the busted changelog entry and (hopefully) fixes the directory ownership issue.

Spec URL: http://threebean.org/rpm/python-tw2-dynforms.spec
SRPM URL: http://threebean.org/rpm/python-tw2-dynforms-2.0.1-2.fc17.src.rpm

Looks good.  This package is APPROVED.

New Package SCM Request
=======================
Package Name: python-tw2-dynforms
Short Description: Dynamic forms for ToscaWidgets2
Owners: ralph
Branches: f17 el6
InitialCC:

Git done (by process-git-requests).

python-tw2-dynforms-2.0.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-tw2-dynforms-2.0.1-3.fc17

python-tw2-dynforms-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-tw2-dynforms-2.0.1-3.el6

python-tw2-dynforms-2.0.1-3.fc17 has been pushed to the Fedora 17 testing repository.

python-tw2-dynforms-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

python-tw2-dynforms-2.0.1-3.fc17 has been pushed to the Fedora 17 stable repository.

Package Change Request
======================
Package Name: python-tw2-dynforms
New Branches: epel7
Owners: ralph
InitialCC:

Git done (by process-git-requests).