Bug 811864

Summary: Server xlator uses different identifiers for 'clients' in accept and disconnect log messages
Product: [Community] GlusterFS Reporter: krishnan parthasarathi <kparthas>
Component: protocolAssignee: krishnan parthasarathi <kparthas>
Status: CLOSED CURRENTRELEASE QA Contact: Anush Shetty <ashetty>
Severity: medium Docs Contact:
Priority: high    
Version: mainlineCC: gluster-bugs, nsathyan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-24 17:31:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 817967    

Description krishnan parthasarathi 2012-04-12 07:22:03 UTC 
Description of problem:
Using different identifiers, namely peerinfo->identifier and conn->id for 'clients' when logging the connection accept event and disconnect event respectively, makes it nearly impossible to find the correspondence between the identifiers and the actual machine.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create volume of any type.
2. Start the volume and mount it.
3. Kill the mount process or bring the interface down in the client machine
(Assuming client and (at least one) brick reside on different machines).
4. Observe the log messages involving "accept" and "disconnect".

In the steps described above, there is atmost one client and the correspondence between the different identifiers and the actual machine involved is obvious. When there are more than one client (mount process) involved, it becomes difficult.
  
Actual results:


Expected results:


Additional info:
Comment 1 Amar Tumballi 2012-04-13 02:15:46 UTC 
kp already sent a patch for this.
Comment 2 Anand Avati 2012-04-13 07:59:21 UTC 
CHANGE: http://review.gluster.com/3133 (server: Modified logging information to ease log based analysis) merged in master by Vijay Bellur (vijay)