Bug 812059
| Summary: | Review Request: python-tw2-jqplugins-flot - jQuery flot (plotting) for ToscaWidgets2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michel, notting, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-26 07:58:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 811739, 811759 | ||
| Bug Blocks: | 818293 | ||
|
Description
Ralph Bean
2012-04-12 16:15:43 UTC
New upstream version fixes test suite. New release cleans up the buildroot stuff. Spec URL: http://threebean.org/rpm/python-tw2-jqplugins-flot.spec SRPM URL: http://threebean.org/rpm/python-tw2-jqplugins-flot-2.0.1-2.fc17.src.rpm A question came up in #fedora-devel as to whether or not we can bundle javascript intended to be served by a web app. There is an explicit exemption in the packaging guidelines making this "OK". http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries Taking this review Same as -gritter -- directory ownership needs fixing
* TODO Review [90%]
- [X] Names [2/2]
- [X] Package name
- [X] Spec name
- [X] Package version [2/2]
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
- [X] Version number
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
- [X] Release tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
- [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
- [X] Source files match upstream
sha256sum ./tw2.jqplugins.flot-2.0.1.tar.gz ~/rpmbuild/SOURCES/tw2.jqplugins.flot-2.0.1.tar.gz
c155703bfd1471b67558e181d41d2065900c56682d81f0cf2ed43b165e65c95e ./tw2.jqplugins.flot-2.0.1.tar.gz
c155703bfd1471b67558e181d41d2065900c56682d81f0cf2ed43b165e65c95e /home/michel/rpmbuild/SOURCES/tw2.jqplugins.flot-2.0.1.tar.gz
- [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
- [X] License [4/4]
- [X] License is Fedora-approved
- [X] No licensing conflict
- [X] License field accurate
- [X] License included iff packaged by upstream
- [X] rpmlint [2/2]
Harmless spellcheck "warnings" on both RPMs
- [X] on src.rpm
$ rpmlint /var/lib/mock/fedora-17-x86_64/result/python-tw2-jqplugins-flot-2.0.1-2.fc17.src.rpm
python-tw2-jqplugins-flot.src: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry
python-tw2-jqplugins-flot.src: W: summary-not-capitalized C jQuery flot (plotting) for ToscaWidgets2
python-tw2-jqplugins-flot.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
python-tw2-jqplugins-flot.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
- [X] on x86_64.rpm
$ rpmlint /var/lib/mock/fedora-17-x86_64/result/python-tw2-jqplugins-flot-2.0.1-2.fc17.noarch.rpm
python-tw2-jqplugins-flot.noarch: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry
python-tw2-jqplugins-flot.noarch: W: summary-not-capitalized C jQuery flot (plotting) for ToscaWidgets2
python-tw2-jqplugins-flot.noarch: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
python-tw2-jqplugins-flot.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
- [X] Language & locale [2/2]
- [X] Spec in US English
- [X] Spec legible
- [-] Build [2/3]
- [X] Koji results
local mock in lieue of Koji
- [X] BRs complete
- [ ] Directory ownership
The wildcard makes this package also owns the following, which
should be owned by packages it depend on:
%{python_sitelib}/tw2
%{python_sitelib}/tw2/jqplugins
Perhaps change this to:
%{python_sitelib}/tw2.jqplugins.flot*
%{python_sitelib}/tw2/jqplugins/flot
- [X] Spec inspection [5/5]
- [X] No duplicate files
- [X] File permissions
- [X] Filenames must be UTF-8
- [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
- [X] Macro usage consistent
note that you can just use 0%{?rhel} rather than
%{?rhel}%{!?rhel:0}
Fixes to directory ownership. Thanks! Spec URL: http://threebean.org/rpm/python-tw2-jqplugins-flot.spec SRPM URL: http://threebean.org/rpm/python-tw2-jqplugins-flot-2.0.1-3.fc17.src.rpm Everything looks good -- APPROVED New Package SCM Request ======================= Package Name: python-tw2-jqplugins-flot Short Description: jQuery flot (plotting) for ToscaWidgets2 Owners: ralph Branches: f17 el6 InitialCC: Thanks for the reviews! Git done (by process-git-requests). python-tw2-jqplugins-flot-2.0.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-tw2-jqplugins-flot-2.0.1-3.fc17 python-tw2-jqplugins-flot-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tw2-jqplugins-flot-2.0.1-3.el6 python-tw2-jqplugins-flot-2.0.1-3.fc17 has been pushed to the Fedora 17 testing repository. python-tw2-jqplugins-flot-2.0.1-3.fc17 has been pushed to the Fedora 17 stable repository. python-tw2-jqplugins-flot-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: python-tw2-jqplugins-flot New Branches: epel7 Owners: ralph InitialCC: Git done (by process-git-requests). |